Prevent cross-site pages when --site-per-process is passed

content/browser/renderer_host/render_view_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_view_host_impl.h"
 
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 1719 matching lines @@
     // The renderer treats all URLs in the about: scheme as being about:blank.
     // Canonicalize about: URLs to about:blank.
     *url = GURL(chrome::kAboutBlankURL);
   }
 
   // Do not allow browser plugin guests to navigate to non-web URLs, since they
   // cannot swap processes or grant bindings.
   bool non_web_url_in_guest = process->IsGuest() &&
       !(url->is_valid() && policy->IsWebSafeScheme(url->scheme()));
 
-  if (non_web_url_in_guest || !policy->CanRequestURL(process->GetID(), *url)) {
+  if (non_web_url_in_guest ||
+      !policy->CanRequestURL(process->GetID(),
+                             *url, ResourceType::MAIN_FRAME)) {

[irobert, 2012/11/28 01:27:57]

It is hard to tell whether this navigation is main frame or iframe. But it
doesn't affect our access control decision.

[Charlie Reis, 2012/11/28 18:58:26]

Hmm, actually, this is problematic.  FilterURL gets called for all sorts of
things, like referrers, form URLs, link URLs, etc.  Maybe we should rethink the
decision to change CanRequestURL if it's used here...

[irobert, 2012/11/28 22:50:41]

Done.

     // If this renderer is not permitted to request this URL, we invalidate the
     // URL.  This prevents us from storing the blocked URL and becoming confused
     // later.
     VLOG(1) << "Blocked URL " << url->spec();
     *url = GURL(chrome::kAboutBlankURL);
   }
 }
 
 void RenderViewHostImpl::SetAltErrorPageURL(const GURL& url) {
   Send(new ViewMsg_SetAltErrorPageURL(GetRoutingID(), url));
@@ skipping 277 matching lines @@
   is_waiting_for_beforeunload_ack_ = false;
   is_waiting_for_unload_ack_ = false;
   has_timed_out_on_unload_ = false;
 }
 
 void RenderViewHostImpl::ClearPowerSaveBlockers() {
   STLDeleteValues(&power_save_blockers_);
 }
 
 }  // namespace content