Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issue 11416095: Merge 134917 - Web Inspector: [Overrides] Device metrics get reset on navigation, yet remain in the… (Closed)

Created:
8 years, 1 month ago by apavlov
Modified:
8 years, 1 month ago
Reviewers:
apavlov
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 134917 - Web Inspector: [Overrides] Device metrics get reset on navigation, yet remain in the Overrides view https://bugs.webkit.org/show_bug.cgi?id=102467 Reviewed by Pavel Feldman. Restore the device metrics overrides from the inspector cookie in InspectorPageAgent::restore(). Drive-by: move the script execution and FPS counter display state restoration from enable() into restore(), so that they will get restored only upon page navigation, not upon any agent enablement. * inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::restore): Restore device metrics overrides, script execution and FPS counter display state. (WebCore::InspectorPageAgent::enable): Don't restore script execution and FPS counter display state on any enablement. TBR=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135250

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M Source/WebCore/inspector/InspectorPageAgent.cpp View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
apavlov
8 years, 1 month ago (2012-11-20 06:05:21 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698