runtime/vm/parser.cc - Issue 11416094: Use the Equals method for C strings when comparing against C strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 11416094: Use the Equals method for C strings when comparing against C strings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/parser.cc

diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc

index 4c9027bcb0527501b2903b73db70eb6bab0c2d81..eb848bb1f42e0e8d0c24eda70946d26d2a9b1e18 100644

--- a/runtime/vm/parser.cc

+++ b/runtime/vm/parser.cc

@@ -6736,9 +6736,7 @@ String* Parser::ExpectIdentifier(const char* msg) {

bool Parser::IsLiteral(const char* literal) {

- const uint8_t* characters = reinterpret_cast<const uint8_t*>(literal);

- intptr_t len = strlen(literal);

- return IsIdentifier() && CurrentLiteral()->Equals(characters, len);

+ return IsIdentifier() && CurrentLiteral()->Equals(literal);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »