Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: webkit/fileapi/media/mtp_device_delegate.h

Issue 11416089: [Media Galleries] Filesystem interface for Mac PTP/MTP devices using ImageCaptureCore (part 3) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Disable GalleryNameMTP test for mac Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | webkit/fileapi/media/mtp_device_file_system_config.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/fileapi/media/mtp_device_delegate.h
diff --git a/webkit/fileapi/media/mtp_device_delegate.h b/webkit/fileapi/media/mtp_device_delegate.h
index a5e89acdff865b413132960d3a31d5cef7c5b6a4..31569d24cfd7ea2d7e18b2be14ca1bdc8848a00f 100644
--- a/webkit/fileapi/media/mtp_device_delegate.h
+++ b/webkit/fileapi/media/mtp_device_delegate.h
@@ -31,14 +31,20 @@ class MTPDeviceDelegate {
// Returns a pointer to a new instance of AbstractFileEnumerator to enumerate
// the file entries of |root| path. The instance needs to be freed by the
// caller, and its lifetime should not extend past when the current call
- // returns to the main media task runner thread.
+ // returns to the main media task runner thread. Callers must ensure the
+ // lifetime of the enumerator is shorter than the MTPDeviceDelegate
+ // implementation itself. Calls to the enumerator are made in the context of
+ // a SeuqencedWorkerPool, and the enumerator may block while it is being
+ // called.
virtual scoped_ptr<FileSystemFileUtil::AbstractFileEnumerator>
CreateFileEnumerator(const base::FilePath& root,
bool recursive) = 0;
// Updates the temporary snapshot file contents given by |local_path| with
// media file contents given by |device_file_path| and also returns the
- // metadata of the temporary file.
+ // metadata of the temporary file. All calls to this interface method are
+ // made in the context of a SequencedWorkerPool, and so only one call will be
+ // active at once. Implementations may block this pool.
virtual base::PlatformFileError CreateSnapshotFile(
const base::FilePath& device_file_path,
const base::FilePath& local_path,
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | webkit/fileapi/media/mtp_device_file_system_config.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698