Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Side by Side Diff: src/isolate.cc

Issue 11416068: Fix typo in condition when to log code objects during deserialization. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2010 matching lines...) Expand 10 before | Expand all | Expand 10 after
2021 2021
2022 // Quiet the heap NaN if needed on target platform. 2022 // Quiet the heap NaN if needed on target platform.
2023 if (!create_heap_objects) Assembler::QuietNaN(heap_.nan_value()); 2023 if (!create_heap_objects) Assembler::QuietNaN(heap_.nan_value());
2024 2024
2025 deoptimizer_data_ = new DeoptimizerData; 2025 deoptimizer_data_ = new DeoptimizerData;
2026 runtime_profiler_ = new RuntimeProfiler(this); 2026 runtime_profiler_ = new RuntimeProfiler(this);
2027 runtime_profiler_->SetUp(); 2027 runtime_profiler_->SetUp();
2028 2028
2029 // If we are deserializing, log non-function code objects and compiled 2029 // If we are deserializing, log non-function code objects and compiled
2030 // functions found in the snapshot. 2030 // functions found in the snapshot.
2031 if (create_heap_objects && 2031 if (!create_heap_objects &&
2032 (FLAG_log_code || FLAG_ll_prof || logger_->is_logging_code_events())) { 2032 (FLAG_log_code || FLAG_ll_prof || logger_->is_logging_code_events())) {
2033 HandleScope scope; 2033 HandleScope scope;
2034 LOG(this, LogCodeObjects()); 2034 LOG(this, LogCodeObjects());
2035 LOG(this, LogCompiledFunctions()); 2035 LOG(this, LogCompiledFunctions());
2036 } 2036 }
2037 2037
2038 CHECK_EQ(static_cast<int>(OFFSET_OF(Isolate, state_)), 2038 CHECK_EQ(static_cast<int>(OFFSET_OF(Isolate, state_)),
2039 Internals::kIsolateStateOffset); 2039 Internals::kIsolateStateOffset);
2040 CHECK_EQ(static_cast<int>(OFFSET_OF(Isolate, embedder_data_)), 2040 CHECK_EQ(static_cast<int>(OFFSET_OF(Isolate, embedder_data_)),
2041 Internals::kIsolateEmbedderDataOffset); 2041 Internals::kIsolateEmbedderDataOffset);
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
2160 2160
2161 #ifdef DEBUG 2161 #ifdef DEBUG
2162 #define ISOLATE_FIELD_OFFSET(type, name, ignored) \ 2162 #define ISOLATE_FIELD_OFFSET(type, name, ignored) \
2163 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_); 2163 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_);
2164 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET) 2164 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET)
2165 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET) 2165 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET)
2166 #undef ISOLATE_FIELD_OFFSET 2166 #undef ISOLATE_FIELD_OFFSET
2167 #endif 2167 #endif
2168 2168
2169 } } // namespace v8::internal 2169 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698