Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4763)

Unified Diff: chrome/browser/ui/browser_window.h

Issue 11416047: Add mac UI for password generation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments and tests Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index c97ee42f32730b954b2dc19a9dd6162437041ea2..10406bfcaf58f80152fa93daba94b82a2dc5b7cd 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -361,13 +361,11 @@ class BrowserWindow : public BaseWindow {
// Show bubble for password generation positioned relative to |rect|. The
// subclasses implementing this interface do not own the |password_generator|
// object which is passed to generate the password. |form| is the form that
- // contains the password field that the bubble will be associated with. A
- // stub implementation is provided since this feature is currently not
- // available on mac.
+ // contains the password field that the bubble will be associated with.
virtual void ShowPasswordGenerationBubble(
const gfx::Rect& rect,
const content::PasswordForm& form,
- autofill::PasswordGenerator* password_generator) {}
+ autofill::PasswordGenerator* password_generator) = 0;
protected:
friend void browser::CloseAllBrowsers();

Powered by Google App Engine
This is Rietveld 408576698