Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 11416036: Android WebView: allow for multiple target architectures. (Closed)

Created:
8 years, 1 month ago by Torne
Modified:
8 years, 1 month ago
CC:
chromium-reviews, klundberg+watch_chromium.org, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, pam+watch_chromium.org, peter+watch_chromium.org, android-webview-reviews_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Android WebView: allow for multiple target architectures. The WebView will eventually need to be built for multiple target architectures. Prepare for this by passing --suffix .arm to gyp when generating the makefiles, and including an architecture-specific makefile at the top level. Also, remove the hardcoding of arm as the target architecture in envsetup.sh. The previous change I made to .gitignore to only ignore *.host.mk and *.target.mk instead of *.mk has been reverted in favour of just specifically un-ignoring files called Android.mk (which are handwritten). BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168506

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M .gitignore View 3 chunks +2 lines, -2 lines 0 comments Download
M Android.mk View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/tools/gyp_webview View 1 chunk +2 lines, -2 lines 1 comment Download
M build/android/envsetup_functions.sh View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Torne
8 years, 1 month ago (2012-11-16 14:06:33 UTC) #1
benm (inactive)
lgtm https://chromiumcodereview.appspot.com/11416036/diff/1/android_webview/tools/gyp_webview File android_webview/tools/gyp_webview (right): https://chromiumcodereview.appspot.com/11416036/diff/1/android_webview/tools/gyp_webview#newcode16 android_webview/tools/gyp_webview:16: . build/android/envsetup.sh --target-arch=arm #TODO: set target-arch and suffix ...
8 years, 1 month ago (2012-11-16 14:24:05 UTC) #2
Torne
On 2012/11/16 14:24:05, benm wrote: > lgtm > > https://chromiumcodereview.appspot.com/11416036/diff/1/android_webview/tools/gyp_webview > File android_webview/tools/gyp_webview (right): > ...
8 years, 1 month ago (2012-11-16 14:27:22 UTC) #3
benm (inactive)
> Rather than use $(TARGET_ARCH) here I'll be generating makefiles for both once > we ...
8 years, 1 month ago (2012-11-16 14:38:34 UTC) #4
mnaganov (inactive)
8 years, 1 month ago (2012-11-16 15:01:19 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698