Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1141603003: Convert cr-settings-main to Polymer 0.8 (Closed)

Created:
5 years, 7 months ago by michaelpg
Modified:
5 years, 7 months ago
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-polymer_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert cr-settings-main to Polymer 0.8 This hasn't been thoroughly tested yet. Once more pages are ready and the rest of the structure is in place I will look more closely at how pages are selected BUG=485381 Committed: https://crrev.com/f8682c0659117a571813de84f7f033e7eab69153 Cr-Commit-Position: refs/heads/master@{#329485}

Patch Set 1 #

Total comments: 12

Patch Set 2 : Feedback #

Patch Set 3 : missing license header #

Patch Set 4 : oops, remove structure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -88 lines) Patch
A + chrome/browser/resources/settings/settings_main/settings_main.css View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.html View 1 2 chunks +29 lines, -15 lines 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.js View 1 5 chunks +33 lines, -30 lines 0 comments Download
D chrome/browser/resources/settings/settings_main/settings_main_style.html View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 2 chunks +63 lines, -12 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
michaelpg
5 years, 7 months ago (2015-05-12 17:30:43 UTC) #2
michaelpg
5 years, 7 months ago (2015-05-12 17:31:04 UTC) #4
Jeremy Klein
https://codereview.chromium.org/1141603003/diff/1/chrome/browser/resources/settings/settings_main/settings_main.html File chrome/browser/resources/settings/settings_main/settings_main.html (right): https://codereview.chromium.org/1141603003/diff/1/chrome/browser/resources/settings/settings_main/settings_main.html#newcode19 chrome/browser/resources/settings/settings_main/settings_main.html:19: <cr-settings-page-header selectedPage="[[selectedPage]]"> selected-page? https://codereview.chromium.org/1141603003/diff/1/chrome/browser/resources/settings/settings_main/settings_main.html#newcode23 chrome/browser/resources/settings/settings_main/settings_main.html:23: <iron-pages id="pageContainer" selectedItem="{{selectedPage}}" should ...
5 years, 7 months ago (2015-05-12 18:18:40 UTC) #5
michaelpg
https://codereview.chromium.org/1141603003/diff/1/chrome/browser/resources/settings/settings_main/settings_main.html File chrome/browser/resources/settings/settings_main/settings_main.html (right): https://codereview.chromium.org/1141603003/diff/1/chrome/browser/resources/settings/settings_main/settings_main.html#newcode19 chrome/browser/resources/settings/settings_main/settings_main.html:19: <cr-settings-page-header selectedPage="[[selectedPage]]"> On 2015/05/12 18:18:39, Jeremy Klein wrote: > ...
5 years, 7 months ago (2015-05-12 18:42:50 UTC) #6
Jeremy Klein
lgtm
5 years, 7 months ago (2015-05-12 18:44:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141603003/20001
5 years, 7 months ago (2015-05-12 18:47:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/63069) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-05-12 18:57:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141603003/30001
5 years, 7 months ago (2015-05-12 19:30:03 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/71225)
5 years, 7 months ago (2015-05-12 19:43:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141603003/50001
5 years, 7 months ago (2015-05-12 19:48:18 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 7 months ago (2015-05-12 21:02:01 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 21:05:08 UTC) #21
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/f8682c0659117a571813de84f7f033e7eab69153
Cr-Commit-Position: refs/heads/master@{#329485}

Powered by Google App Engine
This is Rietveld 408576698