Move RequestPpapiBrokerPermission from WebContentsObserver to WebContentsDelegate.

content/public/browser/web_contents_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/web_contents_delegate.h"
 
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/memory/singleton.h"
 #include "content/public/browser/render_view_host.h"
@@ skipping 125 matching lines @@
 }
 
 void WebContentsDelegate::WebIntentDispatch(
     WebContents* web_contents,
     WebIntentsDispatcher* intents_dispatcher) {
   // The caller passes this method ownership of the |intents_dispatcher|, but
   // this empty implementation will not use it, so we delete it immediately.
   delete intents_dispatcher;
 }
 
+void WebContentsDelegate::RequestPpapiBrokerPermission(
+    WebContents* web_contents,
+    const GURL& url,
+    const FilePath& plugin_path,
+    const base::Callback<void(bool)>& callback) {
+  callback.Run(false);

[jam, 2012/11/16 17:46:40]

nit: don't add this function body, just leave it empty. in general, void
functions are empty in the delegate interfaces. these are not meant to be
"sample" or "basic" interfaces. if you really want, you can have a bool return
value here since we do implement bodies with return values.

[Bernhard Bauer, 2012/11/19 08:55:17]

Done. I use a return value of false here and true in "real" implementations now
to make sure that we don't ever drop the callback (which would result in very
subtle issues).

+}
+
 WebContentsDelegate::~WebContentsDelegate() {
   while (!attached_contents_.empty()) {
     WebContents* web_contents = *attached_contents_.begin();
     web_contents->SetDelegate(NULL);
   }
   DCHECK(attached_contents_.empty());
 }
 
 void WebContentsDelegate::Attach(WebContents* web_contents) {
   DCHECK(attached_contents_.find(web_contents) == attached_contents_.end());
   attached_contents_.insert(web_contents);
 }
 
 void WebContentsDelegate::Detach(WebContents* web_contents) {
   DCHECK(attached_contents_.find(web_contents) != attached_contents_.end());
   attached_contents_.erase(web_contents);
 }
 
 }  // namespace content