Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: chrome/browser/ui/tab_contents/tab_contents.cc

Issue 11416013: Move RequestPpapiBrokerPermission from WebContentsObserver to WebContentsDelegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/tab_contents/tab_contents.h" 5 #include "chrome/browser/ui/tab_contents/tab_contents.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/lazy_instance.h" 8 #include "base/lazy_instance.h"
9 #include "chrome/browser/autofill/autofill_external_delegate.h" 9 #include "chrome/browser/autofill/autofill_external_delegate.h"
10 #include "chrome/browser/autofill/autofill_manager.h" 10 #include "chrome/browser/autofill/autofill_manager.h"
11 #include "chrome/browser/automation/automation_tab_helper.h" 11 #include "chrome/browser/automation/automation_tab_helper.h"
12 #include "chrome/browser/content_settings/tab_specific_content_settings.h" 12 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
13 #include "chrome/browser/extensions/api/web_navigation/web_navigation_api.h" 13 #include "chrome/browser/extensions/api/web_navigation/web_navigation_api.h"
14 #include "chrome/browser/extensions/tab_helper.h" 14 #include "chrome/browser/extensions/tab_helper.h"
15 #include "chrome/browser/external_protocol/external_protocol_observer.h" 15 #include "chrome/browser/external_protocol/external_protocol_observer.h"
16 #include "chrome/browser/favicon/favicon_tab_helper.h" 16 #include "chrome/browser/favicon/favicon_tab_helper.h"
17 #include "chrome/browser/history/history_tab_helper.h" 17 #include "chrome/browser/history/history_tab_helper.h"
18 #include "chrome/browser/infobars/infobar_tab_helper.h" 18 #include "chrome/browser/infobars/infobar_tab_helper.h"
19 #include "chrome/browser/net/load_time_stats.h" 19 #include "chrome/browser/net/load_time_stats.h"
20 #include "chrome/browser/net/net_error_tab_helper.h" 20 #include "chrome/browser/net/net_error_tab_helper.h"
21 #include "chrome/browser/omnibox_search_hint.h" 21 #include "chrome/browser/omnibox_search_hint.h"
22 #include "chrome/browser/password_manager/password_manager.h" 22 #include "chrome/browser/password_manager/password_manager.h"
23 #include "chrome/browser/password_manager/password_manager_delegate_impl.h" 23 #include "chrome/browser/password_manager/password_manager_delegate_impl.h"
24 #include "chrome/browser/pepper_broker_observer.h"
25 #include "chrome/browser/plugins/plugin_observer.h" 24 #include "chrome/browser/plugins/plugin_observer.h"
26 #include "chrome/browser/prerender/prerender_tab_helper.h" 25 #include "chrome/browser/prerender/prerender_tab_helper.h"
27 #include "chrome/browser/printing/print_preview_message_handler.h" 26 #include "chrome/browser/printing/print_preview_message_handler.h"
28 #include "chrome/browser/printing/print_view_manager.h" 27 #include "chrome/browser/printing/print_view_manager.h"
29 #include "chrome/browser/safe_browsing/safe_browsing_tab_observer.h" 28 #include "chrome/browser/safe_browsing/safe_browsing_tab_observer.h"
30 #include "chrome/browser/sessions/session_tab_helper.h" 29 #include "chrome/browser/sessions/session_tab_helper.h"
31 #include "chrome/browser/ssl/ssl_tab_helper.h" 30 #include "chrome/browser/ssl/ssl_tab_helper.h"
32 #include "chrome/browser/tab_contents/navigation_metrics_recorder.h" 31 #include "chrome/browser/tab_contents/navigation_metrics_recorder.h"
33 #include "chrome/browser/thumbnails/thumbnail_tab_helper.h" 32 #include "chrome/browser/thumbnails/thumbnail_tab_helper.h"
34 #include "chrome/browser/translate/translate_tab_helper.h" 33 #include "chrome/browser/translate/translate_tab_helper.h"
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 ExternalProtocolObserver::CreateForWebContents(contents); 136 ExternalProtocolObserver::CreateForWebContents(contents);
138 FaviconTabHelper::CreateForWebContents(contents); 137 FaviconTabHelper::CreateForWebContents(contents);
139 FindTabHelper::CreateForWebContents(contents); 138 FindTabHelper::CreateForWebContents(contents);
140 HistoryTabHelper::CreateForWebContents(contents); 139 HistoryTabHelper::CreateForWebContents(contents);
141 HungPluginTabHelper::CreateForWebContents(contents); 140 HungPluginTabHelper::CreateForWebContents(contents);
142 InfoBarTabHelper::CreateForWebContents(contents); 141 InfoBarTabHelper::CreateForWebContents(contents);
143 NavigationMetricsRecorder::CreateForWebContents(contents); 142 NavigationMetricsRecorder::CreateForWebContents(contents);
144 PasswordManagerDelegateImpl::CreateForWebContents(contents); 143 PasswordManagerDelegateImpl::CreateForWebContents(contents);
145 PasswordManager::CreateForWebContentsAndDelegate( 144 PasswordManager::CreateForWebContentsAndDelegate(
146 contents, PasswordManagerDelegateImpl::FromWebContents(contents)); 145 contents, PasswordManagerDelegateImpl::FromWebContents(contents));
147 PepperBrokerObserver::CreateForWebContents(contents);
148 PluginObserver::CreateForWebContents(contents); 146 PluginObserver::CreateForWebContents(contents);
149 PrefsTabHelper::CreateForWebContents(contents); 147 PrefsTabHelper::CreateForWebContents(contents);
150 prerender::PrerenderTabHelper::CreateForWebContents(contents); 148 prerender::PrerenderTabHelper::CreateForWebContents(contents);
151 safe_browsing::SafeBrowsingTabObserver::CreateForWebContents(contents); 149 safe_browsing::SafeBrowsingTabObserver::CreateForWebContents(contents);
152 SearchEngineTabHelper::CreateForWebContents(contents); 150 SearchEngineTabHelper::CreateForWebContents(contents);
153 chrome::search::SearchTabHelper::CreateForWebContents(contents); 151 chrome::search::SearchTabHelper::CreateForWebContents(contents);
154 SnapshotTabHelper::CreateForWebContents(contents); 152 SnapshotTabHelper::CreateForWebContents(contents);
155 SSLTabHelper::CreateForWebContents(contents); 153 SSLTabHelper::CreateForWebContents(contents);
156 TabContentsSyncedTabDelegate::CreateForWebContents(contents); 154 TabContentsSyncedTabDelegate::CreateForWebContents(contents);
157 TabSpecificContentSettings::CreateForWebContents(contents); 155 TabSpecificContentSettings::CreateForWebContents(contents);
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 228
231 //////////////////////////////////////////////////////////////////////////////// 229 ////////////////////////////////////////////////////////////////////////////////
232 // WebContentsObserver overrides 230 // WebContentsObserver overrides
233 231
234 void TabContents::WebContentsDestroyed(WebContents* tab) { 232 void TabContents::WebContentsDestroyed(WebContents* tab) {
235 // Destruction of the WebContents should only be done by us from our 233 // Destruction of the WebContents should only be done by us from our
236 // destructor. Otherwise it's very likely we (or one of the helpers we own) 234 // destructor. Otherwise it's very likely we (or one of the helpers we own)
237 // will attempt to access the WebContents and we'll crash. 235 // will attempt to access the WebContents and we'll crash.
238 DCHECK(in_destructor_); 236 DCHECK(in_destructor_);
239 } 237 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698