Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 11416006: Added FD_CLOEXEC flag to client/server socket file descriptors (Closed)

Created:
8 years, 1 month ago by kustermann
Modified:
8 years, 1 month ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added FD_CLOEXEC flag to client/server socket file descriptors Without the FD_CLOEXEC, all subprocesses will inherit the open socket file descriptors of the current process due to the default behavior of fork()+exec(). Committed: https://code.google.com/p/dart/source/detail?r=14952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M runtime/bin/fdutils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/fdutils_android.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/bin/fdutils_linux.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/bin/fdutils_macos.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/bin/socket_android.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/bin/socket_linux.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/bin/socket_macos.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kustermann
PTAL
8 years, 1 month ago (2012-11-15 11:20:57 UTC) #1
Mads Ager (google)
8 years, 1 month ago (2012-11-15 11:24:05 UTC) #2
LGTM!!!

Thanks for fixing this Martin. For extra context for people doing a drive-by,
this means that sub-processes that have not yet died cannot block the reuse of a
server socket used in the parent process.

Powered by Google App Engine
This is Rietveld 408576698