Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Issue 1141593004: core_services: Use network_service in core_services on android. (Closed)

Created:
5 years, 7 months ago by Elliot Glaysher
Modified:
5 years, 7 months ago
CC:
chromium-reviews, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

core_services: Use network_service in core_services on android. There was a mismatch between core_services_initialization.cc, the BUILD.gn file, and the package listing. BUG=484234 Committed: https://crrev.com/37d19150ba0d4c59754d786d21d610c2eead7d45 Cr-Commit-Position: refs/heads/master@{#330181}

Patch Set 1 #

Patch Set 2 : Fix ifdefs #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M mandoline/services/core_services/BUILD.gn View 1 chunk +1 line, -4 lines 1 comment Download
M mandoline/services/core_services/core_services_application_delegate.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Elliot Glaysher
If you look in core_services_initialization.cc, you'll see that we're unconditionally redirecting the network_service to core_services. ...
5 years, 7 months ago (2015-05-15 19:24:26 UTC) #2
Ben Goodger (Google)
lgtm
5 years, 7 months ago (2015-05-15 19:25:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141593004/20001
5 years, 7 months ago (2015-05-15 19:30:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 20:12:11 UTC) #6
325583992843-0clp48nf3nc7pk3ll9lp3k65k4ra53j4
Patchset 2 (id:??) landed as https://crrev.com/37d19150ba0d4c59754d786d21d610c2eead7d45 Cr-Commit-Position: refs/heads/master@{#330181}
5 years, 7 months ago (2015-05-16 05:29:45 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:26:45 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/37d19150ba0d4c59754d786d21d610c2eead7d45
Cr-Commit-Position: refs/heads/master@{#330181}

Powered by Google App Engine
This is Rietveld 408576698