Add presubmit trybot for skia.

Add presubmit trybot for skia.

BUG=420910
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295294

[Adrian Kuegel, 2015-05-12 13:19:57]

akuegel@chromium.org changed reviewers:
+ borenet@chromium.org

[Adrian Kuegel, 2015-05-12 13:19:58]

Eric, can you please review this CL?

[borenet, 2015-05-12 16:33:50]

borenet@google.com changed reviewers:
+ borenet@google.com

[borenet, 2015-05-12 16:33:50]

LGTM.  Feel free to restart the master any time, but try not to interrupt any
builds.

https://codereview.chromium.org/1141583002/diff/40001/masters/master.client.s...
File masters/master.client.skia.fyi/builders.cfg (right):

https://codereview.chromium.org/1141583002/diff/40001/masters/master.client.s...
masters/master.client.skia.fyi/builders.cfg:24: 'do_trybot': True },
Just so you're aware, this will create two bots:
- skia_presubmit
- skia_presubmit-Trybot

That's fine with me - there's value in having a waterfall bot running the
presubmit.

[Adrian Kuegel, 2015-05-18 11:44:24]

akuegel@chromium.org changed reviewers:
+ sergiyb@chromium.org

[Adrian Kuegel, 2015-05-18 11:44:26]

Erik, thanks for the review, and sorry that I didn't proceed with this CL until
now. Last Wednesday I was busy with other stuff, and then Thursday and Friday I
was OOO.

@Sergiy: can you please take a look?

https://codereview.chromium.org/1141583002/diff/40001/masters/master.client.s...
File masters/master.client.skia.fyi/builders.cfg (right):

https://codereview.chromium.org/1141583002/diff/40001/masters/master.client.s...
masters/master.client.skia.fyi/builders.cfg:24: 'do_trybot': True },
On 2015/05/12 16:33:50, borenet wrote:
> Just so you're aware, this will create two bots:
> - skia_presubmit
> - skia_presubmit-Trybot
> 
> That's fine with me - there's value in having a waterfall bot running the
> presubmit.

I was not actually aware of this, I only wanted to create the
skia_presubmit-Trybot. But you are right, there is also value in having a
waterfall bot. And it looks to me like skia_master_utils.py does not allow to
create just a Trybot without the waterfall bot as well.

https://codereview.chromium.org/1141583002/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/gclient/config.py (right):

https://codereview.chromium.org/1141583002/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/gclient/config.py:384:
@config_ctx(config_vars={'GIT_MODE': True})
Question @sergiyb: Do you think I should rather move this to the skia recipe
module, and add the skia dependency to the run_presubmit recipe? Or is it ok
like this?

[borenet, 2015-05-18 12:05:50]

https://codereview.chromium.org/1141583002/diff/40001/masters/master.client.s...
File masters/master.client.skia.fyi/builders.cfg (right):

https://codereview.chromium.org/1141583002/diff/40001/masters/master.client.s...
masters/master.client.skia.fyi/builders.cfg:24: 'do_trybot': True },
On 2015/05/18 11:44:26, Adrian Kuegel wrote:
> On 2015/05/12 16:33:50, borenet wrote:
> > Just so you're aware, this will create two bots:
> > - skia_presubmit
> > - skia_presubmit-Trybot
> > 
> > That's fine with me - there's value in having a waterfall bot running the
> > presubmit.
> 
> I was not actually aware of this, I only wanted to create the
> skia_presubmit-Trybot. But you are right, there is also value in having a
> waterfall bot. And it looks to me like skia_master_utils.py does not allow to
> create just a Trybot without the waterfall bot as well.

Yeah, the skia_master_utils were created under the assumption that we almost
always want to duplicate our waterfall bots as trybots.  I don't know that we've
ever needed to add a trybot that wasn't a clone of one of our waterfall bots.

[Sergiy Byelozyorov, 2015-05-18 14:27:06]

lgtm

https://codereview.chromium.org/1141583002/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/gclient/config.py (right):

https://codereview.chromium.org/1141583002/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/gclient/config.py:384:
@config_ctx(config_vars={'GIT_MODE': True})
On 2015/05/18 11:44:26, Adrian Kuegel wrote:
> Question @sergiyb: Do you think I should rather move this to the skia recipe
> module, and add the skia dependency to the run_presubmit recipe? Or is it ok
> like this?

I think it's fine here.

[Adrian Kuegel, 2015-05-18 14:27:56]

The CQ bit was checked by akuegel@chromium.org

[commit-bot: I haz the power, 2015-05-18 14:28:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1141583002/40001

[commit-bot: I haz the power, 2015-05-18 14:36:44]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295294