Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1141573003: Fix BrowserAccessibilityManager initialization race. (Closed)

Created:
5 years, 7 months ago by dmazzoni
Modified:
5 years, 7 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix BrowserAccessibilityManager initialization race. I think this regressed due to: https://codereview.chromium.org/1119923002 BUG=486851 Committed: https://crrev.com/6ee288a5be2c4aed73a35e92a18ce03bbc132447 Cr-Commit-Position: refs/heads/master@{#329492}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/accessibility/browser_accessibility_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dmazzoni
David Trainor, could you review this? The other main Android accessibility reviewer, Peter, is out ...
5 years, 7 months ago (2015-05-12 19:15:57 UTC) #2
dmazzoni
Actually I think it was a bug all along, but that change just made it ...
5 years, 7 months ago (2015-05-12 19:17:29 UTC) #3
David Trainor- moved to gerrit
lgtm. Nice catch!
5 years, 7 months ago (2015-05-12 21:12:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141573003/1
5 years, 7 months ago (2015-05-12 21:18:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 21:23:06 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 21:25:07 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6ee288a5be2c4aed73a35e92a18ce03bbc132447
Cr-Commit-Position: refs/heads/master@{#329492}

Powered by Google App Engine
This is Rietveld 408576698