Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1141573002: [net/proxy] Usage of ThreadTaskRunnerHandle & SingleThreadTaskRunner instead of MLP (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, anujsharma, Randy Smith (Not in Mondays)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecation of MessageLoopProxy usage with ThreadTaskRunnerHandle in net/proxy module. BUG=391045 Committed: https://crrev.com/55c065b684f16cee1c73e7ef803764f22a4fb281 Cr-Commit-Position: refs/heads/master@{#330039}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -64 lines) Patch
M net/proxy/multi_threaded_proxy_resolver.cc View 5 chunks +11 lines, -10 lines 0 comments Download
M net/proxy/network_delegate_error_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/network_delegate_error_observer.cc View 6 chunks +16 lines, -15 lines 0 comments Download
M net/proxy/network_delegate_error_observer_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/polling_proxy_config_service.cc View 8 chunks +20 lines, -21 lines 0 comments Download
M net/proxy/proxy_config_service_linux_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_resolver_v8_tracing.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_resolver_v8_tracing.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/proxy/proxy_service_v8.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-05-12 13:11:29 UTC) #2
Randy Smith (Not in Mondays)
This is probably a fine change, but I've never worked in the proxy code, so ...
5 years, 7 months ago (2015-05-12 14:02:30 UTC) #4
eroman
lgtm
5 years, 7 months ago (2015-05-14 23:38:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141573002/1
5 years, 7 months ago (2015-05-15 02:42:14 UTC) #7
Pranay
Hi Eroman, Thanks for the LGTM
5 years, 7 months ago (2015-05-15 02:42:35 UTC) #8
eroman
No problem! If the code is good I am happy to sign off on it ...
5 years, 7 months ago (2015-05-15 02:44:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 04:19:08 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 04:19:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55c065b684f16cee1c73e7ef803764f22a4fb281
Cr-Commit-Position: refs/heads/master@{#330039}

Powered by Google App Engine
This is Rietveld 408576698