Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1141563003: DEPS: Download binutils before updating clang (Closed)

Created:
5 years, 7 months ago by hans
Modified:
5 years, 7 months ago
Reviewers:
Nico, pcc1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DEPS: Download binutils before updating clang The binutils headers are used for building LLVM's gold plugin, so should be downloaded before running update.sh, which in some configurations builds Clang locally. BUG=452726 Committed: https://crrev.com/b2eae9746e075c40280a662eeeb8d6aedde52c7d Cr-Commit-Position: refs/heads/master@{#330462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M DEPS View 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
hans
Please take a look.
5 years, 7 months ago (2015-05-18 22:03:45 UTC) #2
Nico
Can you make the commit message a bit more detailed? Why is this needed now ...
5 years, 7 months ago (2015-05-18 22:26:59 UTC) #3
hans
On 2015/05/18 22:26:59, Nico wrote: > Can you make the commit message a bit more ...
5 years, 7 months ago (2015-05-18 22:59:06 UTC) #4
pcc1
On 2015/05/18 22:59:06, hans wrote: > On 2015/05/18 22:26:59, Nico wrote: > > Can you ...
5 years, 7 months ago (2015-05-18 23:43:50 UTC) #5
Nico
lgtm
5 years, 7 months ago (2015-05-18 23:45:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141563003/1
5 years, 7 months ago (2015-05-18 23:49:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 00:53:21 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 00:54:02 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2eae9746e075c40280a662eeeb8d6aedde52c7d
Cr-Commit-Position: refs/heads/master@{#330462}

Powered by Google App Engine
This is Rietveld 408576698