Source/platform/heap/Heap.cpp - Issue 1141543002: Oilpan: add release assert to catch nested GCs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/Heap.cpp

Issue 1141543002: Oilpan: add release assert to catch nested GCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/heap/Heap.cpp

diff --git a/Source/platform/heap/Heap.cpp b/Source/platform/heap/Heap.cpp

index 2388869a44f9d6f473d5184b3a9732703760e7ed..05c7a799f316a4ea43b58f6f0c40d4147ffc18c3 100644

--- a/Source/platform/heap/Heap.cpp

+++ b/Source/platform/heap/Heap.cpp

@@ -2266,6 +2266,7 @@ const char* Heap::gcReasonString(GCReason reason)

void Heap::collectGarbage(ThreadState::StackState stackState, ThreadState::GCType gcType, GCReason reason)

{

ThreadState* state = ThreadState::current();

+ RELEASE_ASSERT(!state->isInGC());

ThreadState::GCState originalGCState = state->gcState();

state->setGCState(ThreadState::StoppingOtherThreads);

« no previous file with comments | « no previous file | no next file » | no next file with comments »