Issue 1141533002: Revert of Disabled WebRtcBrowserTest.CanSetupCallAndSendDtmf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1141533002: Revert of Disabled WebRtcBrowserTest.CanSetupCallAndSendDtmf (Closed)

Created:
5 years, 7 months ago by phoglund_chromium

Modified:
5 years, 7 months ago

Reviewers:
henrika (OOO until Aug 14)

CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Disabled WebRtcBrowserTest.CanSetupCallAndSendDtmf (patchset #1 id:1 of https://codereview.chromium.org/1133063002/) Reason for revert: The test should now work with the more aggressive v8 gc() after a gc fix in the test (https://codereview.chromium.org/1138073003/) Original issue's description: > Disabled WebRtcBrowserTest.CanSetupCallAndSendDtmf > > TBR=tommi > BUG=486654 > > Committed: https://crrev.com/fc57f2cec564c344e3e17023b41c008f574b65a7 > Cr-Commit-Position: refs/heads/master@{#329147} TBR=henrika@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=486654 Committed: https://crrev.com/25a9e6e7d98b8effa1494340adc8da798f566fe2 Cr-Commit-Position: refs/heads/master@{#329376}

Created: 5 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	content/browser/media/webrtc_browsertest.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

phoglund_chromium

Created Revert of Disabled WebRtcBrowserTest.CanSetupCallAndSendDtmf

5 years, 7 months ago (2015-05-12 08:41:36 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141533002/1

5 years, 7 months ago (2015-05-12 08:41:54 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-12 08:43:22 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/25a9e6e7d98b8effa1494340adc8da798f566fe2
Cr-Commit-Position: refs/heads/master@{#329376}