IndexedDB: Constify some getters, use ContainsKey helper

IndexedDB: Constify some getters, use ContainsKey helper

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242032

[jsbell, 2013-12-19 17:24:39]

ericu@ - please take a look?

https://codereview.chromium.org/114153004/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_database.cc (right):

https://codereview.chromium.org/114153004/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_database.cc:71: // Takes ownership of the
connection object.
Any suggestions on making this more obvious?

(Fortunately, it's only used in one place and things will 'asplode all over the
place if someone uses it incorrectly.)

[alecflett, 2013-12-19 21:44:50]

https://codereview.chromium.org/114153004/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_database.cc (right):

https://codereview.chromium.org/114153004/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_database.cc:71: // Takes ownership of the
connection object.
On 2013/12/19 17:24:39, jsbell wrote:
> Any suggestions on making this more obvious?
> 
> (Fortunately, it's only used in one place and things will 'asplode all over
the
> place if someone uses it incorrectly.)

Rename it - user lowercase accessor-style is whats making this look odd.

It should be called something like ReleaseCallbacks() and then use
WARN_UNUSED_RETURN or whatever the directive is.

[jsbell, 2013-12-19 22:55:51]

https://codereview.chromium.org/114153004/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_database.cc (right):

https://codereview.chromium.org/114153004/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_database.cc:71: // Takes ownership of the
connection object.
On 2013/12/19 21:44:51, alecflett wrote:
> On 2013/12/19 17:24:39, jsbell wrote:
> > Any suggestions on making this more obvious?
> > 
> > (Fortunately, it's only used in one place and things will 'asplode all over
> the
> > place if someone uses it incorrectly.)
> 
> Rename it - user lowercase accessor-style is whats making this look odd.
> 
> It should be called something like ReleaseCallbacks() and then use
> WARN_UNUSED_RETURN or whatever the directive is.

Done.

[alecflett, 2013-12-19 23:57:38]

lgtm

[commit-bot: I haz the power, 2013-12-20 00:17:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/114153004/40001

[commit-bot: I haz the power, 2013-12-20 07:38:41]

Change committed as 242032