Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Issue 114153004: IndexedDB: Constify some getters, use ContainsKey helper (Closed)

Created:
7 years ago by jsbell
Modified:
7 years ago
Reviewers:
ericu, alecflett
CC:
chromium-reviews, jsbell, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, cmumford, dgrogan
Visibility:
Public.

Description

IndexedDB: Constify some getters, use ContainsKey helper Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242032

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 3

Patch Set 3 : connection -> ReleaseConnection #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -37 lines) Patch
M content/browser/indexed_db/indexed_db_database.cc View 1 2 16 chunks +36 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jsbell
ericu@ - please take a look? https://codereview.chromium.org/114153004/diff/20001/content/browser/indexed_db/indexed_db_database.cc File content/browser/indexed_db/indexed_db_database.cc (right): https://codereview.chromium.org/114153004/diff/20001/content/browser/indexed_db/indexed_db_database.cc#newcode71 content/browser/indexed_db/indexed_db_database.cc:71: // Takes ownership ...
7 years ago (2013-12-19 17:24:39 UTC) #1
alecflett
https://codereview.chromium.org/114153004/diff/20001/content/browser/indexed_db/indexed_db_database.cc File content/browser/indexed_db/indexed_db_database.cc (right): https://codereview.chromium.org/114153004/diff/20001/content/browser/indexed_db/indexed_db_database.cc#newcode71 content/browser/indexed_db/indexed_db_database.cc:71: // Takes ownership of the connection object. On 2013/12/19 ...
7 years ago (2013-12-19 21:44:50 UTC) #2
jsbell
https://codereview.chromium.org/114153004/diff/20001/content/browser/indexed_db/indexed_db_database.cc File content/browser/indexed_db/indexed_db_database.cc (right): https://codereview.chromium.org/114153004/diff/20001/content/browser/indexed_db/indexed_db_database.cc#newcode71 content/browser/indexed_db/indexed_db_database.cc:71: // Takes ownership of the connection object. On 2013/12/19 ...
7 years ago (2013-12-19 22:55:51 UTC) #3
alecflett
lgtm
7 years ago (2013-12-19 23:57:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/114153004/40001
7 years ago (2013-12-20 00:17:47 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-20 07:38:41 UTC) #6
Message was sent while issue was closed.
Change committed as 242032

Powered by Google App Engine
This is Rietveld 408576698