Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 11415280: [Telemetry] Clean up page_runner.Run loop. (Closed)

Created:
8 years ago by tonyg
Modified:
8 years ago
Reviewers:
dtu, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Clean up page_runner.Run loop. This will make adding retry logic here more sane. BUG=None TEST=Unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -65 lines) Patch
M tools/telemetry/telemetry/page_runner.py View 3 chunks +70 lines, -65 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tonyg
ptal
8 years ago (2012-12-04 05:21:14 UTC) #1
nduca
THING OF BEAUTY lgtm
8 years ago (2012-12-04 05:25:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/11415280/1
8 years ago (2012-12-04 09:20:56 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-04 12:07:36 UTC) #4
Message was sent while issue was closed.
Change committed as 170937

Powered by Google App Engine
This is Rietveld 408576698