Issue 11415256: Revert 170387 as it fails presubmit checks locally and on the trybots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11415256: Revert 170387 as it fails presubmit checks locally and on the trybots (Closed)

Created:
8 years ago by Timur Iskhodzhanov

Modified:
8 years ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 170387 as it fails presubmit checks locally and on the trybots Add a tool to look for unused suppressions. BUG=112065 Review URL: https://chromiumcodereview.appspot.com/11421163 TBR=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170727

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -67 lines)			Patch
M	tools/valgrind/suppressions.py	View	1 chunk	+0 lines, -36 lines	0 comments	Download
M	tools/valgrind/test_suppressions.py	View	3 chunks	+34 lines, -7 lines	0 comments	Download
D	tools/valgrind/unused_suppressions.py	View	1 chunk	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

8 years ago (2012-12-10 19:24:39 UTC) #2

Message was sent while issue was closed.

LGTM

Sorry for (unwillingly) breaking PRESUBMIT.py for you. Note that it was already
pretty fragile wrt PYTHONPATH. I'm going to also fix the root cause.

Expand Messages | Collapse Messages