Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 11415243: Linux: use generated library loader for libspeechd. (Closed)

Created:
8 years ago by Paweł Hajdan Jr.
Modified:
8 years ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, Aaron Boodman, pam+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Linux: use generated library loader for libspeechd. This will require an update to build/install-build-deps.sh (done in a separate CL as requested by the infra team). BUG=162733 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173550

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -262 lines) Patch
M build/linux/system.gyp View 1 2 chunks +57 lines, -0 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api_linux.cc View 5 chunks +96 lines, -262 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/generate_library_loader/generate_library_loader.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
8 years ago (2012-11-30 23:06:48 UTC) #1
dmazzoni
lgtm This looks fine to me, but dtseng authored the majority of this code, he ...
8 years ago (2012-12-03 22:00:03 UTC) #2
David Tseng
8 years ago (2012-12-05 00:22:54 UTC) #3
lgtm


On Mon, Dec 3, 2012 at 2:00 PM, <dmazzoni@chromium.org> wrote:

> lgtm
>
> This looks fine to me, but dtseng authored the majority of this code, he
> should
> review too.
>
>
>
https://codereview.chromium.**org/11415243/<https://codereview.chromium.org/1...
>

Powered by Google App Engine
This is Rietveld 408576698