Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11415238: events: Allow retrieving the current event being dispatched from EventDispatcher. (Closed)

Created:
8 years ago by sadrul
Modified:
8 years ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

events: Allow retrieving the current event being dispatched from EventDispatcher. BUG=163607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170574

Patch Set 1 : self-nits #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -22 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 5 chunks +22 lines, -14 lines 0 comments Download
M ui/base/events/event_dispatcher.h View 4 chunks +15 lines, -3 lines 0 comments Download
M ui/base/events/event_dispatcher.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sadrul
8 years ago (2012-11-30 21:17:31 UTC) #1
Ben Goodger (Google)
https://codereview.chromium.org/11415238/diff/6/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://codereview.chromium.org/11415238/diff/6/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode1700 content/browser/renderer_host/render_widget_host_view_aura.cc:1700: event->details().touch_points() == 1) nit: braces https://codereview.chromium.org/11415238/diff/6/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode1740 content/browser/renderer_host/render_widget_host_view_aura.cc:1740: const ui::Event* ...
8 years ago (2012-11-30 21:29:02 UTC) #2
sadrul
https://codereview.chromium.org/11415238/diff/6/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://codereview.chromium.org/11415238/diff/6/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode1700 content/browser/renderer_host/render_widget_host_view_aura.cc:1700: event->details().touch_points() == 1) On 2012/11/30 21:29:02, Ben Goodger (Google) ...
8 years ago (2012-11-30 21:36:13 UTC) #3
sadrul
I notice you just reverted the original CL. Did that break something?
8 years ago (2012-11-30 21:41:14 UTC) #4
Ben Goodger (Google)
8 years ago (2012-11-30 22:20:22 UTC) #5 
lgtm

Powered by Google App Engine
This is Rietveld 408576698