Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1141523002: Implement unaligned allocate and allocate heap numbers in runtime double unaligned. (Closed)

Created:
5 years, 7 months ago by Hannes Payer (out of office)
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement unaligned allocate and allocate heap numbers in runtime double unaligned. In follow-up CLs the scavenger and the MC collector should also respect the unalignment of heap numbers. BUG= Committed: https://crrev.com/7fcbeb289d4333facaa01b9786cec7eee9b07044 Cr-Commit-Position: refs/heads/master@{#28360}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -50 lines) Patch
M src/globals.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 chunks +27 lines, -8 lines 0 comments Download
M src/heap/heap-inl.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M src/heap/spaces.h View 1 4 chunks +7 lines, -6 lines 0 comments Download
M src/heap/spaces.cc View 1 3 chunks +10 lines, -4 lines 0 comments Download
M src/heap/spaces-inl.h View 1 2 3 4 7 chunks +29 lines, -13 lines 0 comments Download
M src/objects.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Hannes Payer (out of office)
5 years, 7 months ago (2015-05-12 08:33:50 UTC) #2
Benedikt Meurer
LGTM with comments. https://codereview.chromium.org/1141523002/diff/60001/src/heap/spaces-inl.h File src/heap/spaces-inl.h (right): https://codereview.chromium.org/1141523002/diff/60001/src/heap/spaces-inl.h#newcode366 src/heap/spaces-inl.h:366: kWordAligned); You really want to DCHECK ...
5 years, 7 months ago (2015-05-12 09:08:39 UTC) #5
Hannes Payer (out of office)
https://codereview.chromium.org/1141523002/diff/60001/src/heap/spaces-inl.h File src/heap/spaces-inl.h (right): https://codereview.chromium.org/1141523002/diff/60001/src/heap/spaces-inl.h#newcode366 src/heap/spaces-inl.h:366: kWordAligned); On 2015/05/12 09:08:39, Benedikt Meurer wrote: > You ...
5 years, 7 months ago (2015-05-12 11:14:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141523002/80001
5 years, 7 months ago (2015-05-12 11:16:21 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-12 11:44:53 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 11:45:06 UTC) #11
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/7fcbeb289d4333facaa01b9786cec7eee9b07044
Cr-Commit-Position: refs/heads/master@{#28360}

Powered by Google App Engine
This is Rietveld 408576698