Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/browser_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc
index cbe1829f3be0c7f22e0b4824d8ff97aa86a25923..0edce69a86c4cb587e9c8818fe9b38ad6aea676b 100644
--- a/chrome/browser/ui/webui/options/browser_options_handler.cc
+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc
@@ -781,7 +781,7 @@ bool BrowserOptionsHandler::IsInteractiveSetDefaultPermitted() {
}
void BrowserOptionsHandler::SetDefaultBrowserUIString(int status_string_id) {
- scoped_ptr<Value> status_string(Value::CreateStringValue(
+ scoped_ptr<Value> status_string(new base::StringValue(
l10n_util::GetStringFUTF16(status_string_id,
l10n_util::GetStringUTF16(IDS_PRODUCT_NAME))));
@@ -1374,7 +1374,7 @@ void BrowserOptionsHandler::SetupPageZoomSelector() {
ListValue* option = new ListValue();
double factor = *i;
int percent = static_cast<int>(factor * 100 + 0.5);
- option->Append(Value::CreateStringValue(
+ option->Append(new base::StringValue(
l10n_util::GetStringFUTF16Int(IDS_ZOOM_PERCENT, percent)));
option->Append(Value::CreateDoubleValue(factor));
bool selected = content::ZoomValuesEqual(factor, default_zoom_factor);

Powered by Google App Engine
This is Rietveld 408576698