chrome/browser/ui/webui/options/chromeos/language_hangul_handler.cc - Issue 11415226: webui/options: Do not use Value::CreateStringValue.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/options/chromeos/language_hangul_handler.cc

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/language_options_util.h » ('j') | chrome/browser/ui/webui/options/chromeos/language_options_util.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/webui/options/chromeos/language_hangul_handler.h"	5 #include "chrome/browser/ui/webui/options/chromeos/language_hangul_handler.h"

6	6

7 #include "base/utf_string_conversions.h"	7 #include "base/utf_string_conversions.h"

8 #include "base/values.h"	8 #include "base/values.h"

9 #include "chrome/browser/chromeos/language_preferences.h"	9 #include "chrome/browser/chromeos/language_preferences.h"

10 #include "grit/generated_resources.h"	10 #include "grit/generated_resources.h"

(...skipping 18 matching lines...) Expand all Loading...
29 localized_strings->SetString("hangul_keyboard_layout",	29 localized_strings->SetString("hangul_keyboard_layout",

30 l10n_util::GetStringUTF16(IDS_OPTIONS_SETTINGS_KEYBOARD_LAYOUT_TEXT));	30 l10n_util::GetStringUTF16(IDS_OPTIONS_SETTINGS_KEYBOARD_LAYOUT_TEXT));

31	31

32 localized_strings->Set("HangulkeyboardLayoutList", GetKeyboardLayoutList());	32 localized_strings->Set("HangulkeyboardLayoutList", GetKeyboardLayoutList());

33 }	33 }

34	34

35 ListValue* LanguageHangulHandler::GetKeyboardLayoutList() {	35 ListValue* LanguageHangulHandler::GetKeyboardLayoutList() {

36 ListValue* keyboard_layout_list = new ListValue();	36 ListValue* keyboard_layout_list = new ListValue();

37 for (size_t i = 0; i < language_prefs::kNumHangulKeyboardNameIDPairs; ++i) {	37 for (size_t i = 0; i < language_prefs::kNumHangulKeyboardNameIDPairs; ++i) {

38 ListValue* option = new ListValue();	38 ListValue* option = new ListValue();

39 option->Append(Value::CreateStringValue(	39 option->Append(new base::StringValue(

40 language_prefs::kHangulKeyboardNameIDPairs[i].keyboard_id));	40 language_prefs::kHangulKeyboardNameIDPairs[i].keyboard_id));

41 option->Append(Value::CreateStringValue(l10n_util::GetStringUTF16(	41 option->Append(new base::StringValue(l10n_util::GetStringUTF16(

42 language_prefs::kHangulKeyboardNameIDPairs[i].message_id)));	42 language_prefs::kHangulKeyboardNameIDPairs[i].message_id)));

43 keyboard_layout_list->Append(option);	43 keyboard_layout_list->Append(option);

44 }	44 }

45 return keyboard_layout_list;	45 return keyboard_layout_list;

46 }	46 }

47	47

48 } // namespace options	48 } // namespace options

49 } // namespace chromeos	49 } // namespace chromeos

OLD	NEW