Http cache: fix a bug that prevented the infinite cache simulation from saving

net/http/infinite_cache_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/infinite_cache.h"
 
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
+#include "base/stringprintf.h"
 #include "base/threading/platform_thread.h"
 #include "base/time.h"
 #include "net/base/net_errors.h"
 #include "net/base/test_completion_callback.h"
 #include "net/http/http_transaction_unittest.h"
 #include "net/http/http_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::Time;
 using base::TimeDelta;
@@ skipping 219 matching lines @@
   // Make sure the data is deleted from disk.
   EXPECT_EQ(net::OK, cb.GetResult(cache->FlushDataForTest(cb.callback())));
   cache.reset(new InfiniteCache);
   cache->Init(path);
 
   EXPECT_EQ(1, cb.GetResult(cache->QueryItemsForTest(cb.callback())));
   ProcessRequest(kTypicalGET_Transaction, cache.get());
   EXPECT_EQ(1, cb.GetResult(cache->QueryItemsForTest(cb.callback())));
 #endif  // OS_ANDROID
 }
+
+#if 0

[tburkard, 2012/11/30 19:00:54]

How about not using #if 0, but making it Disabled, so that one can still run it
manually if needed?

[rvargas (doing something else), 2012/11/30 19:12:23]

I don't care that much either way, but we have regular cycles of "what are we
doing with disabled tests, we should delete them or fix them" (which is 100%
valid concern) so I wanted to be explicit about this being intentional and not a
bug (plus less noise for everybody with "you have n disabled tests"). Running it
is a matter of removing two lines and a few seconds recompiling.

Sounds reasonable?

+// This test is too slow for the bots.
+TEST(InfiniteCache, FillUp) {
+  base::ScopedTempDir dir;
+  ASSERT_TRUE(dir.CreateUniqueTempDir());
+  FilePath path = dir.path().Append(FILE_PATH_LITERAL("infinite"));
+
+  scoped_ptr<InfiniteCache> cache(new InfiniteCache);
+  cache->Init(path);
+  net::TestCompletionCallback cb;
+
+  const int kNumEntries = 25000;
+  for (int i = 0; i < kNumEntries; i++) {
+    std::string url = StringPrintf("http://foo.com/%d/foo.html", i);
+    MockTransaction transaction = kTypicalGET_Transaction;
+    transaction.url = url.c_str();
+    ProcessRequest(transaction, cache.get());
+  }
+
+  EXPECT_EQ(kNumEntries, cb.GetResult(cache->QueryItemsForTest(cb.callback())));
+  EXPECT_EQ(net::OK, cb.GetResult(cache->FlushDataForTest(cb.callback())));
+
+  cache.reset(new InfiniteCache);
+  cache->Init(path);
+  EXPECT_EQ(kNumEntries, cb.GetResult(cache->QueryItemsForTest(cb.callback())));
+}
+#endif