Add support for autofilling radio buttons and checkboxes.

chrome/browser/autofill/autofill_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
@@ skipping 643 matching lines @@
   }
 
   void AutocompleteSuggestionsReturned(const std::vector<string16>& result) {
     autofill_manager_->autocomplete_history_manager_.SendSuggestions(&result);
   }
 
   void FormsSeen(const std::vector<FormData>& forms) {
     autofill_manager_->OnFormsSeen(forms, base::TimeTicks());
   }
 
+  void LoadServerPredictions(const std::string& response_xml) {
+    autofill_manager_->OnLoadedServerPredictions(response_xml);
+  }
+
   void FormSubmitted(const FormData& form) {
     if (autofill_manager_->OnFormSubmitted(form, base::TimeTicks::Now()))
       autofill_manager_->WaitForAsyncFormSubmit();
   }
 
   void FillAutofillFormData(int query_id,
                             const FormData& form,
                             const FormFieldData& field,
                             int unique_id) {
     autofill_manager_->OnFillAutofillFormData(query_id, form, field, unique_id);
@@ skipping 1129 matching lines @@
   GUIDPair empty(std::string(), 0);
   FillAutofillFormData(kDefaultPageID, form, *form.fields.begin(),
                        PackGUIDs(guid, empty));
 
   int page_id = 0;
   FormData results;
   EXPECT_TRUE(GetAutofillFormDataFilledMessage(&page_id, &results));
   ExpectFilledCreditCardFormElvis(page_id, results, kDefaultPageID, false);
 }
 
+TEST_F(AutofillManagerTest, FillCheckableElements) {
+  FormData form;
+  CreateTestAddressFormData(&form);
+
+  // Add a checkbox field.
+  FormFieldData field;
+  autofill_test::CreateTestFormField(
+      "Checkbox", "checkbx", "fill-me", "checkbox", &field);
+  field.is_checkable = true;
+  form.fields.push_back(field);
+  autofill_test::CreateTestFormField(
+      "Checkbox", "checkbx", "dont-fill-me", "checkbox", &field);

[Ilya Sherman, 2012/12/07 01:47:22]

nit: I think the test code would be clearer if this string were "fill-me", and
the one on line 1850 were "dont-fill-me"

[Raman Kakilate, 2012/12/10 18:36:45]

Done.

+  field.is_checkable = true;
+  form.fields.push_back(field);
+
+  std::vector<FormData> forms(1, form);
+  FormsSeen(forms);
+
+  // Replicate server response with XML.
+  const std::string response_xml =
+      "<autofillqueryresponse>"
+      "<field autofilltype=\"0\"/>"
+      "<field autofilltype=\"0\"/>"
+      "<field autofilltype=\"0\"/>"
+      "<field autofilltype=\"0\"/>"
+      "<field autofilltype=\"0\"/>"
+      "<field autofilltype=\"0\"/>"
+      "<field autofilltype=\"0\"/>"
+      "<field autofilltype=\"0\"/>"
+      "<field autofilltype=\"0\"/>"
+      "<field autofilltype=\"0\"/>"
+      "<field autofilltype=\"0\"/>"
+      "<field autofilltype=\"61\" defaultvalue=\"fill-me\"/>"
+      "<field autofilltype=\"61\" defaultvalue=\"fill-me\"/>"
+      "</autofillqueryresponse>";
+  LoadServerPredictions(response_xml);
+
+  GUIDPair guid("00000000-0000-0000-0000-000000000001", 0);
+  GUIDPair empty(std::string(), 0);
+  FillAutofillFormData(kDefaultPageID, form, form.fields[0],
+                       PackGUIDs(empty, guid));
+  int page_id = 0;
+  FormData results;
+  EXPECT_TRUE(GetAutofillFormDataFilledMessage(&page_id, &results));
+  // Last but one field should be checked.

[Ilya Sherman, 2012/12/07 01:47:22]

nit: "Last but one" -> "Second to last"

[Raman Kakilate, 2012/12/10 18:36:45]

Done.

+  EXPECT_TRUE(results.fields[results.fields.size()-2].is_checked);
+  // Last field shoutn't be checked as values are not same.

[Ilya Sherman, 2012/12/07 01:47:22]

nit: "shoutn't" -> "shouldn't"

[Raman Kakilate, 2012/12/10 18:36:45]

Done.

+  EXPECT_FALSE(results.fields[results.fields.size()-1].is_checked);
+}
+
 // Test that we correctly fill a credit card form with month input type.
 // 1. year empty, month empty
 TEST_F(AutofillManagerTest, FillCreditCardFormNoYearNoMonth) {
   // Same as the SetUp(), but generate 4 credit cards with year month
   // combination.
   personal_data_.CreateTestCreditCardsYearAndMonth("", "");
   // Set up our form data.
   FormData form;
   CreateTestCreditCardFormData(&form, true, true);
   std::vector<FormData> forms(1, form);
@@ skipping 1332 matching lines @@
 
   FormData form;
   CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
   const FormFieldData& field = form.fields[0];
   GetAutofillSuggestions(form, field);  // should call the delegate's OnQuery()
 
   autofill_manager_->SetExternalDelegate(NULL);
 }