Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Unified Diff: net/spdy/spdy_http_stream_spdy3_unittest.cc

Issue 11415219: Move a number of static variables SPDY to HttpNetworkSession::Params. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moar cleanup Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_http_stream_spdy3_unittest.cc
diff --git a/net/spdy/spdy_http_stream_spdy3_unittest.cc b/net/spdy/spdy_http_stream_spdy3_unittest.cc
index 46a18163ad147088bf7ec80bc5b5c553452b9586..df60217866a8277aca906bfc1b0907633b68b55b 100644
--- a/net/spdy/spdy_http_stream_spdy3_unittest.cc
+++ b/net/spdy/spdy_http_stream_spdy3_unittest.cc
@@ -26,18 +26,19 @@ using namespace net::test_spdy3;
namespace net {
+namespace {
+
+} // namespace
willchan no longer on Chromium 2012/12/01 20:49:13 ?
Ryan Hamilton 2012/12/01 23:02:25 Removed.
+
class SpdyHttpStreamSpdy3Test : public testing::Test {
public:
OrderedSocketData* data() { return data_.get(); }
protected:
- SpdyHttpStreamSpdy3Test() {}
-
- virtual void SetUp() {
- SpdySession::set_default_protocol(kProtoSPDY3);
+ SpdyHttpStreamSpdy3Test()
+ : ec_signature_creator_factory_(new MockECSignatureCreatorFactory()) {
}
virtual void TearDown() {
- crypto::ECSignatureCreator::SetFactoryForTesting(NULL);
UploadDataStream::ResetMergeChunks();
MessageLoop::current()->RunUntilIdle();
}
@@ -84,7 +85,7 @@ class SpdyHttpStreamSpdy3Test : public testing::Test {
scoped_refptr<TransportSocketParams> transport_params_;
private:
- SpdyTestStateHelper spdy_state_;
+ scoped_ptr<MockECSignatureCreatorFactory> ec_signature_creator_factory_;
willchan no longer on Chromium 2012/12/01 20:49:13 Why bother with a scoped_ptr? Do you need to reset
Ryan Hamilton 2012/12/01 23:02:25 Done.
};
TEST_F(SpdyHttpStreamSpdy3Test, SendRequest) {

Powered by Google App Engine
This is Rietveld 408576698