Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5420)

Unified Diff: chrome/test/chromedriver/command_executor_impl.h

Issue 11415205: [chromedriver] Implement connecting to devtools and loading a page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/command_executor_impl.h
diff --git a/chrome/test/chromedriver/command_executor_impl.h b/chrome/test/chromedriver/command_executor_impl.h
index 125b1e3159865cfcac81dfc08f4af47228fd8a9c..07d5ec68ca25c2b1b766eb748f3d47668c68d3b3 100644
--- a/chrome/test/chromedriver/command_executor_impl.h
+++ b/chrome/test/chromedriver/command_executor_impl.h
@@ -12,7 +12,7 @@
#include "base/compiler_specific.h"
#include "base/gtest_prod_util.h"
#include "base/memory/scoped_ptr.h"
-#include "chrome/test/chromedriver/chrome_launcher_impl.h"
+#include "base/threading/thread.h"
#include "chrome/test/chromedriver/command.h"
#include "chrome/test/chromedriver/command_executor.h"
#include "chrome/test/chromedriver/session_map.h"
@@ -24,11 +24,16 @@ class DictionaryValue;
class Value;
}
+class ChromeLauncherImpl;
+class URLRequestContextGetter;
+
class CommandExecutorImpl : public CommandExecutor {
public:
CommandExecutorImpl();
virtual ~CommandExecutorImpl();
+ virtual void Init() OVERRIDE;
chrisgao (Use stgao instead) 2012/12/01 08:37:19 Also overridden. Move to after comment "// Overrid
kkania 2013/02/28 21:51:58 Done.
+
// Overridden from CommandExecutor:
virtual void ExecuteCommand(const std::string& name,
const base::DictionaryValue& params,
@@ -43,8 +48,10 @@ class CommandExecutorImpl : public CommandExecutor {
CommandExecutorImplTest, CommandThatDoesntSetValueOrSessionId);
FRIEND_TEST_ALL_PREFIXES(CommandExecutorImplTest, CommandThatReturnsError);
+ base::Thread io_thread_;
+ scoped_refptr<URLRequestContextGetter> context_getter_;
SessionMap session_map_;
- ChromeLauncherImpl launcher_;
+ scoped_ptr<ChromeLauncherImpl> launcher_;
SynchronizedMap<std::string, Command> command_map_;
DISALLOW_COPY_AND_ASSIGN(CommandExecutorImpl);

Powered by Google App Engine
This is Rietveld 408576698