Introduce callback for resolving global object name while taking heap snapshot

Introduce callback for resolving global object name while taking heap snapshot

Heap profiler currently gets "document" of global objects while taking snapshot (to later retrieve its "URL"). This is unsafe as there may be no current v8 context when the property is requested while corresponding property accessor may make some assumptions about the context stack during its invokation. Several crashes were reported due to this problem:
https://bugs.webkit.org/show_bug.cgi?id=103076
https://crbug.com/162121
https://crbug.com/132727

This patch adds a callback for resolving global object names and avoid the crashes.
Committed: https://code.google.com/p/v8/source/detail?r=13137

[alph, 2012-12-03 18:31:15]

lgtm

https://codereview.chromium.org/11415203/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/11415203/diff/1/src/api.cc#newcode6612
src/api.cc:6612: 
You've lost an empty line.

https://codereview.chromium.org/11415203/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://codereview.chromium.org/11415203/diff/1/src/profile-generator.cc#newc...
src/profile-generator.cc:2723: // This branch is going to be removed once
Chromium migrates to the
nit: TODO

[yurys, 2012-12-03 18:36:05]

https://codereview.chromium.org/11415203/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/11415203/diff/1/src/api.cc#newcode6612
src/api.cc:6612: 
On 2012/12/03 18:31:15, alph wrote:
> You've lost an empty line.

Done.

https://codereview.chromium.org/11415203/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://codereview.chromium.org/11415203/diff/1/src/profile-generator.cc#newc...
src/profile-generator.cc:2723: // This branch is going to be removed once
Chromium migrates to the
On 2012/12/03 18:31:15, alph wrote:
> nit: TODO

Done.

[Michael Starzinger, 2012-12-04 10:40:34]

LGTM.