Chromium Code Reviews
Help | Chromium Project | Sign in
(712)

Issue 11415187: Merge 169130 - Remove self-destruct message box (causing hang in Metro). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by gab
Modified:
1 year, 4 months ago
Reviewers:
gab
CC:
chromium-reviews_chromium.org, grt+watch_chromium.org
Visibility:
Public.

Description

Merge 169130 - Remove self-destruct message box (causing hang in Metro).

Launch self-destruct setup out of job (so that it doesn't die when killing the chrome.exe which created it...).

And be more drastic about killing Chrome processes on force-uninstall (pure kill, no wait).


BUG=158632, 159995
TEST=Install system-level over user-level (with user-level set to run in Metro mode); next run should self-destruct user-level Chrome (silently); subsequent launches should launch system-level Chrome.
This should also fix users currently in this bad state (upon updating the user-level Chrome which will then be able to self-destruct properly).

This might also solve bug 159995, will need to test with official build (it definitely solves the part where when both Chromes are present, user-level is activated, but hangs on the self-destruct message (which can't be displayed in Metro) -- the stronger kill process in this CL might also help with the user-level binaries left behind issue).


Review URL: https://chromiumcodereview.appspot.com/11417036

TBR=gab@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -36 lines) Lint Patch
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +16 lines, -6 lines 0 comments 1 errors Download
M chrome/installer/setup/uninstall.cc View 1 chunk +3 lines, -30 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 1

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434