Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1647)

Unified Diff: sdk/lib/io/http_impl.dart

Issue 11415176: Fix bug in HttpClient, introduced in r15450. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/http_impl.dart
diff --git a/sdk/lib/io/http_impl.dart b/sdk/lib/io/http_impl.dart
index 201c12454b2ac1498a9a67bc0799a1d9d8d0dbd4..8996c0b4f344d4e074ef79f60ff5e01ef6a5988c 100644
--- a/sdk/lib/io/http_impl.dart
+++ b/sdk/lib/io/http_impl.dart
@@ -1839,7 +1839,7 @@ class _HttpClient implements HttpClient {
if (proxyIndex < proxyConfiguration.proxies.length) {
// Try the next proxy in the list.
_establishConnection(
- host, port, proxyConfiguration, proxyIndex, false);
+ host, port, proxyConfiguration, proxyIndex, false, secure);
} else {
// Report the error through the HttpClientConnection object to
// the client.
@@ -1870,13 +1870,13 @@ class _HttpClient implements HttpClient {
}
// Find out if we want a secure socket.
- bool secure = (url.scheme == "https");
+ bool is_secure = (url.scheme == "https");
// Find the TCP host and port.
String host = url.domain;
int port = url.port;
if (port == 0) {
- port = secure ?
+ port = is_secure ?
HttpClient.DEFAULT_HTTPS_PORT :
HttpClient.DEFAULT_HTTP_PORT;
}
@@ -1903,7 +1903,7 @@ class _HttpClient implements HttpClient {
proxyConfiguration,
0,
reusedConnection,
- secure);
+ is_secure);
return connection;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698