Revert "Emit constants using ASTs"

sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 class SsaCodeGeneratorTask extends CompilerTask {
 
   final JavaScriptBackend backend;
 
@@ skipping 1794 matching lines @@
   js.Expression newLiteralBool(bool value) {
     if (compiler.enableMinification) {
       // Use !0 for true, !1 for false.
       return new js.Prefix("!", new js.LiteralNumber(value ? "0" : "1"));
     } else {
       return new js.LiteralBool(value);
     }
   }
 
   void generateConstant(Constant constant) {
-    if (constant.isFunction()) {
-      FunctionConstant function = constant;
-      world.registerStaticUse(function.element);
+    Namer namer = backend.namer;
+    // TODO(floitsch): should we use the ConstantVisitor here?
+    if (!constant.isObject()) {
+      if (constant.isBool()) {
+        BoolConstant boolConstant = constant;
+        push(newLiteralBool(boolConstant.value));
+      } else if (constant.isNum()) {
+        // TODO(floitsch): get rid of the code buffer.
+        CodeBuffer buffer = new CodeBuffer();
+        backend.emitter.writeConstantToBuffer(constant, buffer);
+        push(new js.LiteralNumber(buffer.toString()));
+      } else if (constant.isNull()) {
+        push(new js.LiteralNull());
+      } else if (constant.isString()) {
+        // TODO(floitsch): get rid of the code buffer.
+        CodeBuffer buffer = new CodeBuffer();
+        backend.emitter.writeConstantToBuffer(constant, buffer);
+        push(new js.LiteralString(buffer.toString()));
+      } else if (constant.isFunction()) {
+        FunctionConstant function = constant;
+        world.registerStaticUse(function.element);
+        push(new js.VariableUse(namer.isolateAccess(function.element)));
+      } else if (constant.isSentinel()) {
+        // TODO(floitsch): get rid of the code buffer.
+        CodeBuffer buffer = new CodeBuffer();
+        backend.emitter.writeConstantToBuffer(constant, buffer);
+        push(new js.VariableUse(buffer.toString()));
+      } else {
+        compiler.internalError(
+            "The compiler does not know how generate code for "
+            "constant $constant");
+      }
+    } else {
+      String name = namer.constantName(constant);
+      js.VariableUse currentIsolateUse =
+          new js.VariableUse(backend.namer.CURRENT_ISOLATE);
+      push(new js.PropertyAccess.field(currentIsolateUse, name));
     }
-    push(backend.emitter.constantReference(constant));
   }
 
   visitConstant(HConstant node) {
     assert(isGenerateAtUseSite(node));
     generateConstant(node.constant);
     DartType type = node.constant.computeType(compiler);
     world.registerInstantiatedClass(type.element);
   }
 
   visitLoopBranch(HLoopBranch node) {
@@ skipping 1186 matching lines @@
   if (leftType.canBeNull() && rightType.canBeNull()) {
     if (left.isConstantNull() || right.isConstantNull() ||
         (leftType.isPrimitive() && leftType == rightType)) {
       return '==';
     }
     return null;
   } else {
     return '===';
   }
 }