Texture Draw Calls Coalescing

cc/direct_renderer.cc

Index: cc/direct_renderer.cc
diff --git a/cc/direct_renderer.cc b/cc/direct_renderer.cc
index 9f1311467990b3a97b84b6e6373ca1fe6dd96c3e..7fbd16c58778fb269605d11b0cdac5a0cd13cbb2 100644
--- a/cc/direct_renderer.cc
+++ b/cc/direct_renderer.cc
@@ -207,6 +207,10 @@ void DirectRenderer::setScissorStateForQuadWithRenderPassScissor(const DrawingFr
     setScissorTestRect(moveScissorToWindowSpace(frame, quadScissorRect));
 }
 
+void DirectRenderer::finishDrawingQuadList()

[shawnsingh, 2012/11/28 19:44:16]

I know I was the one who suggested doing it this way, but now I changed my
mind...  since the rest of the drawing-related API is only pure virtual, perhaps
we should also make this pure virtual to be consistent. 

[whunt, 2012/11/28 22:01:15]

DirectRenderer isn't a virtual interface, it's already got tons of
functionality.  I don't see any real logic as to which parts are pure virtual
and which aren't.  This function can certainly be made pure virtual but I don't
see a strong reason to change it.  Is there some convention?

On 2012/11/28 19:44:16, shawnsingh wrote:

[danakj, 2012/11/28 22:03:16]

Things that would be useful for GLRenderer and SoftwareRenderer live in
DirectRenderer. Things that are GL-specific live in the subclass.

Generally the DirectRenderer has the logic to draw a frame, and abstract methods
filled in by GLRenderer or SoftwareRenderer to make it happen.

+{
+}
+
 void DirectRenderer::drawRenderPass(DrawingFrame& frame, const RenderPass* renderPass)
 {
     TRACE_EVENT0("cc", "DirectRenderer::drawRenderPass");
@@ -236,6 +240,7 @@ void DirectRenderer::drawRenderPass(DrawingFrame& frame, const RenderPass* rende
         if (!shouldSkipQuad)
             drawQuad(frame, *it);
     }
+    finishDrawingQuadList();
 
     CachedResource* texture = m_renderPassTextures.get(renderPass->id);
     if (texture)