Issue 11415157: Enable the -Wstrict-prototypes warning for untrusted code in the Gyp build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11415157: Enable the -Wstrict-prototypes warning for untrusted code in the Gyp build (Closed)

Created:
8 years ago by Mark Seaborn

Modified:
6 years, 6 months ago

Reviewers:
bradn

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

Enable the -Wstrict-prototypes warning for untrusted code in the Gyp build I'm adding this in build_nexe.py rather than to 'nacl_default_compile_flags' (in build/untrusted.gypi or build/standalone_flags.gypi), because if I enable the flag for C++ as well as C, Clang complains with: cc1plus: warning: command line option "-Wstrict-prototypes" is valid for C/ObjC but not for C++ BUG=https://code.google.com/p/nativeclient/issues/detail?id=3114 TEST=build R=bradnelson@google.com Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13314

Patch Set 1 #

Patch Set 2 : Avoid warning about C++ #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/build_nexe.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

This depends on a Chromium-side change: https://codereview.chromium.org/312323005/

6 years, 6 months ago (2014-06-05 21:26:18 UTC) #1

Mark Seaborn

6 years, 6 months ago (2014-06-10 23:50:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r13314 (presubmit successful).

Expand Messages | Collapse Messages