Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2507)

Unified Diff: chrome/browser/resources/net_internals/browser_bridge.js

Issue 11415148: Adding error handling to ONC validation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@extract_onc_certificate
Patch Set: Initial patch. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/net_internals/browser_bridge.js
diff --git a/chrome/browser/resources/net_internals/browser_bridge.js b/chrome/browser/resources/net_internals/browser_bridge.js
index 8b396c5fc6e9500fbcdb63a6d4f6623fa106c24b..8f1674f85f605ac129bd16372ed4a6a3f56ca5cd 100644
--- a/chrome/browser/resources/net_internals/browser_bridge.js
+++ b/chrome/browser/resources/net_internals/browser_bridge.js
@@ -352,9 +352,13 @@ var BrowserBridge = (function() {
this.hstsObservers_[i].onHSTSQueryResult(info);
},
- receivedONCFileParse: function(error) {
+ /**
+ * @param {!{message: string, success: boolean}} params Parameter dict.
+ */
+ receivedONCFileParse: function(params) {
for (var i = 0; i < this.crosONCFileParseObservers_.length; i++)
- this.crosONCFileParseObservers_[i].onONCFileParse(error);
+ this.crosONCFileParseObservers_[i].onONCFileParse(params.message,
+ params.success);
},
receivedStoreDebugLogs: function(status) {
@@ -571,7 +575,7 @@ var BrowserBridge = (function() {
* Adds a listener for ONC file parse status. The observer will be called
* back with:
*
- * observer.onONCFileParse(error);
+ * observer.onONCFileParse(error, success);
*/
addCrosONCFileParseObserver: function(observer) {
this.crosONCFileParseObservers_.push(observer);

Powered by Google App Engine
This is Rietveld 408576698