Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: ppapi/proxy/ppb_flash_proxy.cc

Issue 11415140: Refactor 3 PPB_Flash functions to the new resource model. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/ppb_flash_proxy.cc
diff --git a/ppapi/proxy/ppb_flash_proxy.cc b/ppapi/proxy/ppb_flash_proxy.cc
index 0846dde77e75f8217617b832825f7eda0c649aef..4a9cd8f25b03ad37ed3c8ecb94bcf47861c77f10 100644
--- a/ppapi/proxy/ppb_flash_proxy.cc
+++ b/ppapi/proxy/ppb_flash_proxy.cc
@@ -106,8 +106,6 @@ bool PPB_Flash_Proxy::OnMessageReceived(const IPC::Message& msg) {
OnHostMsgSetInstanceAlwaysOnTop)
IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBFlash_DrawGlyphs,
OnHostMsgDrawGlyphs)
- IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBFlash_GetProxyForURL,
- OnHostMsgGetProxyForURL)
IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBFlash_Navigate, OnHostMsgNavigate)
IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBFlash_GetLocalTimeZoneOffset,
OnHostMsgGetLocalTimeZoneOffset)
@@ -178,13 +176,6 @@ PP_Bool PPB_Flash_Proxy::DrawGlyphs(PP_Instance instance,
return result;
}
-PP_Var PPB_Flash_Proxy::GetProxyForURL(PP_Instance instance, const char* url) {
- ReceiveSerializedVarReturnValue result;
- dispatcher()->Send(new PpapiHostMsg_PPBFlash_GetProxyForURL(
- API_ID_PPB_FLASH, instance, url, &result));
- return result.Return(dispatcher());
-}
-
int32_t PPB_Flash_Proxy::Navigate(PP_Instance instance,
PP_Resource request_info,
const char* target,
@@ -261,11 +252,6 @@ PP_Bool PPB_Flash_Proxy::IsRectTopmost(PP_Instance instance,
return result;
}
-void PPB_Flash_Proxy::UpdateActivity(PP_Instance instance) {
- PluginGlobals::Get()->GetBrowserSender()->Send(
- new PpapiHostMsg_PPBFlash_UpdateActivity(API_ID_PPB_FLASH));
-}
-
PP_Var PPB_Flash_Proxy::GetSetting(PP_Instance instance,
PP_FlashSetting setting) {
PluginDispatcher* plugin_dispatcher =
@@ -294,21 +280,6 @@ PP_Var PPB_Flash_Proxy::GetSetting(PP_Instance instance,
return PP_MakeUndefined();
}
-PP_Bool PPB_Flash_Proxy::SetCrashData(PP_Instance instance,
- PP_FlashCrashKey key,
- PP_Var value) {
- switch (key) {
- case PP_FLASHCRASHKEY_URL:
- StringVar *url_string_var(StringVar::FromPPVar(value));
- if (!url_string_var)
- return PP_FALSE;
- std::string url_string(url_string_var->value());
- PluginGlobals::Get()->SetActiveURL(url_string);
- return PP_TRUE;
- }
- return PP_FALSE;
-}
-
bool PPB_Flash_Proxy::CreateThreadAdapterForInstance(PP_Instance instance) {
return true;
}
@@ -527,19 +498,6 @@ void PPB_Flash_Proxy::OnHostMsgDrawGlyphs(
PpapiGlobals::Get()->GetVarTracker()->ReleaseVar(font_desc.face);
}
-void PPB_Flash_Proxy::OnHostMsgGetProxyForURL(PP_Instance instance,
- const std::string& url,
- SerializedVarReturnValue result) {
- EnterInstanceNoLock enter(instance);
- if (enter.succeeded()) {
- result.Return(dispatcher(),
- enter.functions()->GetFlashAPI()->GetProxyForURL(
- instance, url.c_str()));
- } else {
- result.Return(dispatcher(), PP_MakeUndefined());
- }
-}
-
void PPB_Flash_Proxy::OnHostMsgNavigate(PP_Instance instance,
const URLRequestInfoData& data,
const std::string& target,

Powered by Google App Engine
This is Rietveld 408576698