Issue 11415134: Merge 135709 - Circular reference between Document and MediaQueryMatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11415134: Merge 135709 - Circular reference between Document and MediaQueryMatcher. (Closed)

Created:
8 years ago by karen

Modified:
8 years ago

Reviewers:
commit-queue

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/

Visibility:
Public.

Merge 135709 - Circular reference between Document and MediaQueryMatcher. https://bugs.webkit.org/show_bug.cgi?id=103242 Patch by Marja Hölttä <marja@chromium.org>; on 2012-11-26 Reviewed by Kenneth Rohde Christiansen. It's not enough to clean up listeners in MediaQueryMatcher in ~Document, since MediaQueryListListener keeps the Document alive. This caused www.crbug.com/113983. No new tests: No visible change in behavior (except that it doesn't leak memory). * dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::detach): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135747

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	Source/WebCore/dom/Document.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 1 (0 generated)