Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 11415134: Merge 135709 - Circular reference between Document and MediaQueryMatcher. (Closed)

Created:
8 years ago by karen
Modified:
8 years ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 135709 - Circular reference between Document and MediaQueryMatcher. https://bugs.webkit.org/show_bug.cgi?id=103242 Patch by Marja Hölttä <marja@chromium.org>; on 2012-11-26 Reviewed by Kenneth Rohde Christiansen. It's not enough to clean up listeners in MediaQueryMatcher in ~Document, since MediaQueryListListener keeps the Document alive. This caused www.crbug.com/113983. No new tests: No visible change in behavior (except that it doesn't leak memory). * dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::detach): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/WebCore/dom/Document.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years ago (2012-11-26 19:40:18 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698