Dart2js: Fix stack overflow in new String.fromCharCodes bug=6919

Dart2js: Fix stack overflow in new String.fromCharCodes bug=6919
R=floitsch@google.com
BUG=6919
Committed: https://code.google.com/p/dart/source/detail?r=15308

[floitsch, 2012-11-26 12:01:28]

LGTM.

https://codereview.chromium.org/11415130/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (right):

https://codereview.chromium.org/11415130/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:538: // This is to
fix http://dartbug.com/6919
Please add a little bit of context, so that you don't need to go to the
issue-tracker.

https://codereview.chromium.org/11415130/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:539: static String
_doFromCharCode(List<int> array) {
_fromCharCodeApply
?

https://codereview.chromium.org/11415130/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:540: String acc =
"";
result

https://codereview.chromium.org/11415130/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:544: var subarray =
end <= kMaxApply ? array :
nit: I would prefer having an "if" there.

[erikcorry, 2012-12-03 12:37:24]

https://codereview.chromium.org/11415130/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (right):

https://codereview.chromium.org/11415130/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:538: // This is to
fix http://dartbug.com/6919
On 2012/11/26 12:01:28, floitsch wrote:
> Please add a little bit of context, so that you don't need to go to the
> issue-tracker.

Done.

https://codereview.chromium.org/11415130/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:539: static String
_doFromCharCode(List<int> array) {
On 2012/11/26 12:01:28, floitsch wrote:
> _fromCharCodeApply
> ?

Done.

https://codereview.chromium.org/11415130/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:540: String acc =
"";
On 2012/11/26 12:01:28, floitsch wrote:
> result

Done.

https://codereview.chromium.org/11415130/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:544: var subarray =
end <= kMaxApply ? array :
On 2012/11/26 12:01:28, floitsch wrote:
> nit: I would prefer having an "if" there.

Done.

[sra1, 2012-12-03 16:22:44]

https://codereview.chromium.org/11415130/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (right):

https://codereview.chromium.org/11415130/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:545:
JS('List<int>', r'array.slice(#, #)',
JS('=List', ...)

The result of Array.prototype.slice is a JS Array with no type info.