sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart - Issue 11415114: Do not generate empty native classes. Fixes issue 6872.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

Issue 11415114: Do not generate empty native classes. Fixes issue 6872. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('K') | « sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart (revision 15244)

+++ sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart (working copy)

@@ -166,14 +166,15 @@

CodeBuffer fieldBuffer = new CodeBuffer();

CodeBuffer getterSetterBuffer = new CodeBuffer();

+ CodeBuffer methodBuffer = new CodeBuffer();

- emitter.emitClassFields(classElement, fieldBuffer);

- emitter.emitClassGettersSetters(classElement, getterSetterBuffer,

- omitLeadingComma: true);

+ emitter.emitClassFields(

+ classElement, fieldBuffer, emitEndingComma: false);

+ emitter.emitClassGettersSetters(

+ classElement, getterSetterBuffer, emitLeadingComma: false);

+ emitter.emitInstanceMembers(

+ classElement, methodBuffer, emitLeadingComma: false);

- CodeBuffer methodBuffer = new CodeBuffer();

- emitter.emitInstanceMembers(classElement, methodBuffer, false);

if (methodBuffer.isEmpty

&& fieldBuffer.isEmpty

&& getterSetterBuffer.isEmpty) {