sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart - Issue 11415114: Do not generate empty native classes. Fixes issue 6872.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

Issue 11415114: Do not generate empty native classes. Fixes issue 6872. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart (revision 15255)

+++ sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart (working copy)

@@ -133,17 +133,20 @@

buffer.add(' }');

}

- void emitClassFields(ClassElement classElement, CodeBuffer buffer) {

- /* Do nothing. */

+ void emitClassFields(ClassElement classElement,

+ CodeBuffer buffer,

+ bool emitEndingComma) {

+ if (emitEndingComma) buffer.add(', ');

}

- void emitClassGettersSetters(ClassElement classElement, CodeBuffer buffer,

- {bool omitLeadingComma: false}) {

+ void emitClassGettersSetters(ClassElement classElement,

+ CodeBuffer buffer,

+ bool emitLeadingComma) {

emitComma() {

- if (!omitLeadingComma) {

+ if (emitLeadingComma) {

buffer.add(",\n ");

} else {

- omitLeadingComma = false;

+ emitLeadingComma = true;

}