Remove assumption about initial ordinals in app sync tests

Remove assumption about initial ordinals in app sync tests

This fixes a test breakage if a new COMPONENT app is added (in an upcoming CL).


BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169846

[akalin, 2012-11-22 09:34:33]

https://codereview.chromium.org/11415090/diff/1/chrome/browser/sync/test/inte...
File chrome/browser/sync/test/integration/two_client_apps_sync_test.cc (right):

https://codereview.chromium.org/11415090/diff/1/chrome/browser/sync/test/inte...
chrome/browser/sync/test/integration/two_client_apps_sync_test.cc:372:
GetProfile(0)->GetExtensionService()->extension_prefs()
i think a more robust solution would be to get the ordinal of the app after it's
installed and then use that instead of relying on it being the first app
installed.

Can you add a GetAppLaunchOrdinalForApp(Profile*, int) function (similar to
SetAppLaunchOrdinalForApp below) and use that in this test instead?

[akalin, 2012-11-27 04:00:29]

Is this ready for review? (Looks like it)

The CL summary and description is a bit incoherent.  Can you update it to
something like:

Summary:

Remove assumption about initial ordinals in app sync tests

Description:

Remove assumption about initial ordinals in app sync tests

This fixes a test breakage if a new COMPONENT app is added (in an upcoming CL).

Once you do that, LGTM

[Gaurav, 2012-11-27 18:26:38]

Thanks akalin

[commit-bot: I haz the power, 2012-11-27 22:17:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/11415090/1002

[commit-bot: I haz the power, 2012-11-28 00:49:29]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-28 00:52:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/11415090/12002

[commit-bot: I haz the power, 2012-11-28 02:25:39]

Retried try job too often on linux_aura for step(s) aura_unit_tests,
browser_tests, view_unittests

[commit-bot: I haz the power, 2012-11-28 02:43:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/11415090/12002

[commit-bot: I haz the power, 2012-11-28 04:42:16]

Change committed as 169846