FilePathWatcher::Watch() - Listen for sub directory changes.

base/files/file_path_watcher.h

Index: base/files/file_path_watcher.h
diff --git a/base/files/file_path_watcher.h b/base/files/file_path_watcher.h
index 367be9435e9c952b7865b8f0aab3f479eeb6963e..f01f38137880d9a27fc6ccfe1a207001a62a42fd 100644
--- a/base/files/file_path_watcher.h
+++ b/base/files/file_path_watcher.h
@@ -59,6 +59,7 @@ class BASE_EXPORT FilePathWatcher {
 
     // Start watching for the given |path| and notify |delegate| about changes.
     virtual bool Watch(const FilePath& path,
+                       bool recursive,
                        Delegate* delegate) WARN_UNUSED_RESULT = 0;
 
     // Stop watching. This is called from FilePathWatcher's dtor in order to
@@ -115,13 +116,14 @@ class BASE_EXPORT FilePathWatcher {
   // Deprecated: new code should use the callback interface, declared below.
   // The FilePathWatcher::Delegate interface will be removed once all client
   // code has been updated. http://crbug.com/130980
-  virtual bool Watch(const FilePath& path, Delegate* delegate)
+  virtual bool Watch(const FilePath& path, bool recursive, Delegate* delegate)

[Lei Zhang, 2012/11/21 03:36:49]

Do we need this? I don't think anyone will write new code with the deprecated
method and ask for recursive.

[kmadhusu, 2012/11/21 04:13:26]

bool Watch(const FilePath& path, bool recursive, const Callback& callback) calls
this function.

[Lei Zhang, 2012/11/21 04:21:02]

Maybe it's time to make the new Watch() method call impl_->Watch() directly?
We'll eventually do that anyway, since the old Watch() method will eventually go
away.

[kmadhusu, 2012/11/22 01:39:41]

Done.

       WARN_UNUSED_RESULT;
 
   // Invokes |callback| whenever updates to |path| are detected. This should be
-  // called at most once, and from a MessageLoop of TYPE_IO. The callback will
+  // called at most once, and from a MessageLoop of TYPE_IO. Set |recursive| to

[Lei Zhang, 2012/11/21 03:36:49]

"Set |recursive| to true to watch the |path| and its children."

[kmadhusu, 2012/11/21 04:13:26]

Done.

+  // true, to watch the sub trees of the specified |path|. The callback will
   // be invoked on the same loop. Returns true on success.
-  bool Watch(const FilePath& path, const Callback& callback);
+  bool Watch(const FilePath& path, bool recursive, const Callback& callback);
 
  private:
   scoped_refptr<PlatformDelegate> impl_;