Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: base/files/file_path_watcher.h

Issue 11415066: FilePathWatcher::Watch() - Listen for sub directory changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/files/file_path_watcher.cc » ('j') | base/files/file_path_watcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/files/file_path_watcher.h
diff --git a/base/files/file_path_watcher.h b/base/files/file_path_watcher.h
index 367be9435e9c952b7865b8f0aab3f479eeb6963e..651dada0972bea0e65e4e671400eb5e652f7b93f 100644
--- a/base/files/file_path_watcher.h
+++ b/base/files/file_path_watcher.h
@@ -59,6 +59,7 @@ class BASE_EXPORT FilePathWatcher {
// Start watching for the given |path| and notify |delegate| about changes.
virtual bool Watch(const FilePath& path,
+ bool recursive,
Delegate* delegate) WARN_UNUSED_RESULT = 0;
// Stop watching. This is called from FilePathWatcher's dtor in order to
@@ -115,13 +116,14 @@ class BASE_EXPORT FilePathWatcher {
// Deprecated: new code should use the callback interface, declared below.
// The FilePathWatcher::Delegate interface will be removed once all client
// code has been updated. http://crbug.com/130980
- virtual bool Watch(const FilePath& path, Delegate* delegate)
+ virtual bool Watch(const FilePath& path, bool recursive, Delegate* delegate)
Mattias Nissler (ping if slow) 2012/11/21 09:28:48 Don't add recursive here, this is the deprecated i
kmadhusu 2012/11/22 01:39:41 Done. Modified new code to call the impl_->Watch()
WARN_UNUSED_RESULT;
// Invokes |callback| whenever updates to |path| are detected. This should be
- // called at most once, and from a MessageLoop of TYPE_IO. The callback will
- // be invoked on the same loop. Returns true on success.
- bool Watch(const FilePath& path, const Callback& callback);
+ // called at most once, and from a MessageLoop of TYPE_IO. Set |recursive| to
+ // true, to watch |path| and its children. The callback will be invoked on
+ // the same loop. Returns true on success.
Mattias Nissler (ping if slow) 2012/11/21 09:28:48 Please put a note saying that recursive watches ar
kmadhusu 2012/11/22 01:39:41 Done.
+ bool Watch(const FilePath& path, bool recursive, const Callback& callback);
private:
scoped_refptr<PlatformDelegate> impl_;
« no previous file with comments | « no previous file | base/files/file_path_watcher.cc » ('j') | base/files/file_path_watcher.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698