sdk/lib/html/dartium/html_dartium.dart - Issue 11415064: Phase out local storage usage in PortSync code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 11415064: Phase out local storage usage in PortSync code (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Merge Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/html/dartium/html_dartium.dart

diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart

index 6bdad865646150b50ac75557d16a6c9abd4c66e4..22d8fc097d58aa6b5b5838e116d346a7a08cfcb8 100644

--- a/sdk/lib/html/dartium/html_dartium.dart

+++ b/sdk/lib/html/dartium/html_dartium.dart

@@ -15385,7 +15385,7 @@ class LocalWindow extends EventTarget implements Window {

* registered under [name].

lookupPort(String name) {

- var port = JSON.parse(localStorage['dart-port:$name']);

+ var port = JSON.parse(document.documentElement.attributes['dart-port:$name']);

return _deserialize(port);

}

@@ -15396,7 +15396,7 @@ class LocalWindow extends EventTarget implements Window {

registerPort(String name, var port) {

var serialized = _serialize(port);

- localStorage['dart-port:$name'] = JSON.stringify(serialized);

+ document.documentElement.attributes['dart-port:$name'] = JSON.stringify(serialized);

}

LocalWindow.internal(): super.internal();