Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: chrome/browser/sync/invalidations/invalidator_storage.h

Issue 11415049: Implement features needed for local ack handling in InvalidationStateTracker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ...... Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/invalidations/invalidator_storage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/invalidations/invalidator_storage.h
diff --git a/chrome/browser/sync/invalidations/invalidator_storage.h b/chrome/browser/sync/invalidations/invalidator_storage.h
index c0f480fb4111d6893275875d32c262afaddcda9a..19164032760f679028233655d708b4d982bfb663 100644
--- a/chrome/browser/sync/invalidations/invalidator_storage.h
+++ b/chrome/browser/sync/invalidations/invalidator_storage.h
@@ -43,12 +43,19 @@ class InvalidatorStorage : public base::SupportsWeakPtr<InvalidatorStorage>,
// InvalidationStateTracker implementation.
virtual syncer::InvalidationStateMap GetAllInvalidationStates() const
OVERRIDE;
- virtual void SetMaxVersion(const invalidation::ObjectId& id,
- int64 max_version) OVERRIDE;
+ virtual void SetMaxVersionAndPayload(const invalidation::ObjectId& id,
+ int64 max_version,
+ const std::string& payload) OVERRIDE;
virtual void Forget(const syncer::ObjectIdSet& ids) OVERRIDE;
// TODO(tim): These are not yet used. Bug 124140.
virtual void SetBootstrapData(const std::string& data) OVERRIDE;
virtual std::string GetBootstrapData() const OVERRIDE;
+ virtual void GenerateAckHandles(
+ const syncer::ObjectIdSet& ids,
+ const scoped_refptr<base::TaskRunner>& task_runner,
+ base::Callback<void(const syncer::AckHandleMap&)> callback) OVERRIDE;
+ virtual void Acknowledge(const invalidation::ObjectId& id,
+ const syncer::AckHandle& ack_handle) OVERRIDE;
private:
FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, SerializeEmptyMap);
@@ -61,6 +68,8 @@ class InvalidatorStorage : public base::SupportsWeakPtr<InvalidatorStorage>,
FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest,
DeserializeFromEmptyList);
FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeFromListBasic);
+ FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest,
+ DeserializeFromListMissingOptionalValues);
FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeMapOutOfRange);
FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest, DeserializeMapInvalidFormat);
FRIEND_TEST_ALL_PREFIXES(InvalidatorStorageTest,
« no previous file with comments | « no previous file | chrome/browser/sync/invalidations/invalidator_storage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698