Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: src/trusted/validator_mips/ncvalidate.cc

Issue 11415031: [MIPS] Forbid $sp update at the end of the last bundle. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Presubmit errors have been fixed. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator_mips/ncval.cc ('k') | src/trusted/validator_mips/validator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator_mips/ncvalidate.cc
diff --git a/src/trusted/validator_mips/ncvalidate.cc b/src/trusted/validator_mips/ncvalidate.cc
index 64ec34b2b23831b62f0810bcb64a4381e16d4191..3008dd6f947d058659416c99fe7402022d7f4f5b 100644
--- a/src/trusted/validator_mips/ncvalidate.cc
+++ b/src/trusted/validator_mips/ncvalidate.cc
@@ -18,6 +18,7 @@
using nacl_mips_val::SfiValidator;
using nacl_mips_val::CodeSegment;
using nacl_mips_dec::Register;
+using nacl_mips_dec::RegisterList;
using nacl_mips_dec::kRegisterStack;
using nacl_mips_dec::kRegListReserved;
using std::vector;
@@ -85,12 +86,12 @@ EXTERN_C_BEGIN
int NCValidateSegment(uint8_t *mbase, uint32_t vbase, size_t size,
bool stubout_mode) {
SfiValidator validator(
- 16, // 64, // bytes per bundle
- 1U * NACL_DATA_SEGMENT_START, // bytes of code space
- 1U * (1<<NACL_MAX_ADDR_BITS), // bytes of data space // keep in sync w/
- // SConstruct: irt_compatible_rodata_addr
- kRegListReserved, // read only register(s)
- kRegisterStack); // data addressing register(s)
+ 16, // 64, // bytes per bundle
+ 1U * NACL_DATA_SEGMENT_START, // bytes of code space
+ 1U * (1<<NACL_MAX_ADDR_BITS), // bytes of data space // keep in sync w/
+ // SConstruct: irt_compatible_rodata_addr
+ kRegListReserved, // read only register(s)
+ RegisterList(kRegisterStack)); // data addressing register(s)
bool success = false;
vector<CodeSegment> segments;
« no previous file with comments | « src/trusted/validator_mips/ncval.cc ('k') | src/trusted/validator_mips/validator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698