Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1141503003: Revert color analysis optimization which breaks on Android. (Closed)

Created:
5 years, 7 months ago by calamity
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert color analysis optimization which breaks on Android. This CL is a revert of r284166 which caused dominant color calculation on Android to have the wrong swizzle format, producing results with swapped R and B values. BUG=482120 Committed: https://crrev.com/2ade003cadb854dbf60f9840ab8878e90d34750f Cr-Commit-Position: refs/heads/master@{#330046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -30 lines) Patch
M ui/gfx/color_analysis.cc View 5 chunks +7 lines, -30 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
calamity
5 years, 7 months ago (2015-05-14 05:04:01 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 7 months ago (2015-05-14 14:46:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141503003/1
5 years, 7 months ago (2015-05-15 04:09:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 05:01:40 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 05:02:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ade003cadb854dbf60f9840ab8878e90d34750f
Cr-Commit-Position: refs/heads/master@{#330046}

Powered by Google App Engine
This is Rietveld 408576698