Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/lib/string.cc

Issue 11415028: Remove NullPointerException. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixed VM bugs. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/regexp_patch.dart ('k') | runtime/vm/code_generator.cc » ('j') | tests/compiler/dart2js_native/dart2js_native.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/string.cc
diff --git a/runtime/lib/string.cc b/runtime/lib/string.cc
index 76c097abc54cdf991dc46ceba8ff8400caf2ceef..cb3ad4561600e9eb4cdf47867a59ba42e8ed4674 100644
--- a/runtime/lib/string.cc
+++ b/runtime/lib/string.cc
@@ -144,10 +144,6 @@ DEFINE_NATIVE_ENTRY(Strings_concatAll, 1) {
Instance& elem = Instance::Handle();
for (intptr_t i = 0; i < strings.Length(); i++) {
elem ^= strings.At(i);
- if (elem.IsNull()) {
- GrowableArray<const Object*> args;
- Exceptions::ThrowByType(Exceptions::kNullPointer, args);
- }
if (!elem.IsString()) {
GrowableArray<const Object*> args;
args.Add(&elem);
« no previous file with comments | « runtime/lib/regexp_patch.dart ('k') | runtime/vm/code_generator.cc » ('j') | tests/compiler/dart2js_native/dart2js_native.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698